Changing Option String Resource to lowerCamelcases.

Changing Option String Resource to lowerCamelcases in content_settings_handler.cc file.

BUG=469633
Committed: https://crrev.com/5a2a2f2ac5eba84d4c1cf2bf3ba577a57935b54d
Cr-Commit-Position: refs/heads/master@{#322350}

[Deepak, 2015-03-23 10:59:34]

deepak.m1@samsung.com changed reviewers:
+ bauerb@chromium.org

[Deepak, 2015-03-23 10:59:35]

PTAL for changes option resource stings to lowerCamelCases.
Thanks

[Deepak, 2015-03-23 12:20:57]

On 2015/03/23 10:59:35, Deepak wrote:
> PTAL for changes option resource stings to lowerCamelCases.
> Thanks

@Bernhard
Please hold this review, Things are not ready currently.
I will update when it is ready.
Thanks

[Deepak, 2015-03-24 10:29:06]

PTAL for changes option resource stings to lowerCamelCases.
Thanks

[Bernhard Bauer, 2015-03-24 14:03:55]

https://codereview.chromium.org/1021413004/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/content_settings_handler.cc (left):

https://codereview.chromium.org/1021413004/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/content_settings_handler.cc:362:
{"media-stream_header", IDS_MEDIA_STREAM_HEADER},
If you change these (to be exact, if you change the part before _header), you
need to also update the contentType for them in the other files here.

[Deepak, 2015-03-24 14:08:36]

On 2015/03/24 14:03:55, Bernhard Bauer wrote:
>
https://codereview.chromium.org/1021413004/diff/20001/chrome/browser/ui/webui...
> File chrome/browser/ui/webui/options/content_settings_handler.cc (left):
> 
>
https://codereview.chromium.org/1021413004/diff/20001/chrome/browser/ui/webui...
> chrome/browser/ui/webui/options/content_settings_handler.cc:362:
> {"media-stream_header", IDS_MEDIA_STREAM_HEADER},
> If you change these (to be exact, if you change the part before _header), you
> need to also update the contentType for them in the other files here.

ok, I understand,
Can we change "media-stream_header" to "media-streamHeader" and similarly other
also same way that have '-' in it.

[Bernhard Bauer, 2015-03-24 14:20:32]

On 2015/03/24 14:08:36, Deepak wrote:
> On 2015/03/24 14:03:55, Bernhard Bauer wrote:
> >
>
https://codereview.chromium.org/1021413004/diff/20001/chrome/browser/ui/webui...
> > File chrome/browser/ui/webui/options/content_settings_handler.cc (left):
> > 
> >
>
https://codereview.chromium.org/1021413004/diff/20001/chrome/browser/ui/webui...
> > chrome/browser/ui/webui/options/content_settings_handler.cc:362:
> > {"media-stream_header", IDS_MEDIA_STREAM_HEADER},
> > If you change these (to be exact, if you change the part before _header),
you
> > need to also update the contentType for them in the other files here.
> 
> ok, I understand,
> Can we change "media-stream_header" to "media-streamHeader" and similarly
other
> also same way that have '-' in it.

I would prefer not to do that -- "media-streamHeader" looks equally inconsistent
and arguably even more unreadable. If we want to keep the contentType as it is,
we could convert it to camelCase (e.g. via http://stackoverflow.com/a/6661012)
before appending "Header" and looking up the localized string for it.

[Deepak, 2015-03-25 08:00:46]

On 2015/03/24 14:20:32, Bernhard Bauer wrote:
> On 2015/03/24 14:08:36, Deepak wrote:
> > On 2015/03/24 14:03:55, Bernhard Bauer wrote:
> > >
> >
>
https://codereview.chromium.org/1021413004/diff/20001/chrome/browser/ui/webui...
> > > File chrome/browser/ui/webui/options/content_settings_handler.cc (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/1021413004/diff/20001/chrome/browser/ui/webui...
> > > chrome/browser/ui/webui/options/content_settings_handler.cc:362:
> > > {"media-stream_header", IDS_MEDIA_STREAM_HEADER},
> > > If you change these (to be exact, if you change the part before _header),
> you
> > > need to also update the contentType for them in the other files here.
> > 
> > ok, I understand,
> > Can we change "media-stream_header" to "media-streamHeader" and similarly
> other
> > also same way that have '-' in it.
> 
> I would prefer not to do that -- "media-streamHeader" looks equally
inconsistent
> and arguably even more unreadable. If we want to keep the contentType as it
is,
> we could convert it to camelCase (e.g. via http://stackoverflow.com/a/6661012)
> before appending "Header" and looking up the localized string for it.

Changes done as suggested, now we are converting 
"media-stream_header" to "mediaStreamHeader" by converting content type to
camelCaseType and then appending 'Header' to it.
Please take a look.
Thanks

[Deepak, 2015-03-26 08:59:55]

Changes done as suggested, now we are converting 
"media-stream_header" to "mediaStreamHeader" by converting content type to
camelCaseType and then appending 'Header' to it.
Please take a look.
Thanks

[Bernhard Bauer, 2015-03-26 09:05:51]

https://codereview.chromium.org/1021413004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/options/content_settings_exceptions_area.js
(right):

https://codereview.chromium.org/1021413004/diff/60001/chrome/browser/resource...
chrome/browser/resources/options/content_settings_exceptions_area.js:626: return
g[1].toUpperCase(); });
I would indent this in the regular function scope (i.e. two spaces), then break
after the semicolon.

[Deepak, 2015-03-26 09:39:13]

On 2015/03/26 09:05:51, Bernhard Bauer wrote:
>
https://codereview.chromium.org/1021413004/diff/60001/chrome/browser/resource...
> File chrome/browser/resources/options/content_settings_exceptions_area.js
> (right):
> 
>
https://codereview.chromium.org/1021413004/diff/60001/chrome/browser/resource...
> chrome/browser/resources/options/content_settings_exceptions_area.js:626:
return
> g[1].toUpperCase(); });
> I would indent this in the regular function scope (i.e. two spaces), then
break
> after the semicolon.

Changes done.
PTAL
Thanks

[Bernhard Bauer, 2015-03-26 09:43:42]

LGTM

Can you also update the description to mention that this is for content
settings?

[Deepak, 2015-03-26 09:46:25]

On 2015/03/26 09:43:42, Bernhard Bauer wrote:
> LGTM
> 
> Can you also update the description to mention that this is for content
> settings?

Done.
Thanks

[Deepak, 2015-03-26 09:47:37]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2015-03-26 09:47:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1021413004/80001

[commit-bot: I haz the power, 2015-03-26 10:32:48]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-26 10:33:45]

Patchset 5 (id:??) landed as
https://crrev.com/5a2a2f2ac5eba84d4c1cf2bf3ba577a57935b54d
Cr-Commit-Position: refs/heads/master@{#322350}