chrome/browser/resources/options/content_settings_exceptions_area.js - Issue 1021413004: Changing Option String Resource to lowerCamelcases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/content_settings_exceptions_area.js

Issue 1021413004: Changing Option String Resource to lowerCamelcases. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/content_settings_exceptions_area.html ('k') | chrome/browser/ui/webui/options/content_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/content_settings_exceptions_area.js

diff --git a/chrome/browser/resources/options/content_settings_exceptions_area.js b/chrome/browser/resources/options/content_settings_exceptions_area.js

index 74bd582392e281aeb7bcbe65b5598008f0c5e1da..12004a53efdaf3658adecae84492dbefeb1a3c32 100644

--- a/chrome/browser/resources/options/content_settings_exceptions_area.js

+++ b/chrome/browser/resources/options/content_settings_exceptions_area.js

@@ -189,7 +189,7 @@ cr.define('options.contentSettings', function() {

// icon of the app.

if (controlledBy == 'HostedApp') {

this.title =

- loadTimeData.getString('set_by') + ' ' + this.dataItem.appName;

+ loadTimeData.getString('setBy') + ' ' + this.dataItem.appName;

var button = this.querySelector('.row-delete-button');

// Use the host app's favicon (16px, match bigger size).

// See c/b/ui/webui/extensions/extension_icon_source.h

@@ -621,7 +621,10 @@ cr.define('options.contentSettings', function() {

this.title = loadTimeData.getString(type + 'TabTitle');

var header = this.pageDiv.querySelector('h1');

- header.textContent = loadTimeData.getString(type + '_header');

+ var camelCasedType = type.replace(/-([a-z])/g, function(g) {

+ return g[1].toUpperCase();

+ });

+ header.textContent = loadTimeData.getString(camelCasedType + 'Header');

var divs = this.pageDiv.querySelectorAll('div[contentType]');

for (var i = 0; i < divs.length; i++) {