Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: components/favicon.gypi

Issue 1021223002: Remove //components/favicon/core/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/BUILD.gn ('k') | components/favicon/core/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon.gypi
diff --git a/components/favicon.gypi b/components/favicon.gypi
index 09a78f22ce3733c066718f91b90b26510d6e79fa..d5b3e9cb84563fcb1af83c463e7de69e3c68bc61 100644
--- a/components/favicon.gypi
+++ b/components/favicon.gypi
@@ -9,42 +9,25 @@
'target_name': 'favicon_core',
'type': 'static_library',
'dependencies': [
- '../ui/gfx/gfx.gyp:gfx_geometry',
- '../url/url.gyp:url_lib',
- 'favicon_base',
- ],
- 'sources': [
- # Note: sources list duplicated in GN build.
- 'favicon/core/favicon_driver.h',
- 'favicon/core/favicon_url.cc',
- 'favicon/core/favicon_url.h',
- ],
- 'include_dirs': [
- '..',
- ],
- },
- {
- # GN version: //components/favicon/core/browser
- 'target_name': 'favicon_core_browser',
- 'type': 'static_library',
- 'dependencies': [
'../skia/skia.gyp:skia',
'../ui/gfx/gfx.gyp:gfx',
'../url/url.gyp:url_lib',
'bookmarks_browser',
'favicon_base',
- 'favicon_core',
'history_core_browser',
'keyed_service_core',
],
'sources': [
# Note: sources list duplicated in GN build.
- 'favicon/core/browser/favicon_client.h',
- 'favicon/core/browser/favicon_handler.cc',
- 'favicon/core/browser/favicon_handler.h',
- 'favicon/core/browser/favicon_service.cc',
- 'favicon/core/browser/favicon_service.h',
- 'favicon/core/browser/favicon_tab_helper_observer.h',
+ 'favicon/core/favicon_client.h',
+ 'favicon/core/favicon_driver.h',
+ 'favicon/core/favicon_handler.cc',
+ 'favicon/core/favicon_handler.h',
+ 'favicon/core/favicon_service.cc',
+ 'favicon/core/favicon_service.h',
+ 'favicon/core/favicon_tab_helper_observer.h',
+ 'favicon/core/favicon_url.cc',
+ 'favicon/core/favicon_url.h',
],
'include_dirs': [
'..',
« no previous file with comments | « components/BUILD.gn ('k') | components/favicon/core/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698