Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: components/favicon.gypi

Issue 1021223002: Remove //components/favicon/core/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/BUILD.gn ('k') | components/favicon/core/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 # GN version: //components/favicon/core 8 # GN version: //components/favicon/core
9 'target_name': 'favicon_core', 9 'target_name': 'favicon_core',
10 'type': 'static_library', 10 'type': 'static_library',
11 'dependencies': [ 11 'dependencies': [
12 '../ui/gfx/gfx.gyp:gfx_geometry',
13 '../url/url.gyp:url_lib',
14 'favicon_base',
15 ],
16 'sources': [
17 # Note: sources list duplicated in GN build.
18 'favicon/core/favicon_driver.h',
19 'favicon/core/favicon_url.cc',
20 'favicon/core/favicon_url.h',
21 ],
22 'include_dirs': [
23 '..',
24 ],
25 },
26 {
27 # GN version: //components/favicon/core/browser
28 'target_name': 'favicon_core_browser',
29 'type': 'static_library',
30 'dependencies': [
31 '../skia/skia.gyp:skia', 12 '../skia/skia.gyp:skia',
32 '../ui/gfx/gfx.gyp:gfx', 13 '../ui/gfx/gfx.gyp:gfx',
33 '../url/url.gyp:url_lib', 14 '../url/url.gyp:url_lib',
34 'bookmarks_browser', 15 'bookmarks_browser',
35 'favicon_base', 16 'favicon_base',
36 'favicon_core',
37 'history_core_browser', 17 'history_core_browser',
38 'keyed_service_core', 18 'keyed_service_core',
39 ], 19 ],
40 'sources': [ 20 'sources': [
41 # Note: sources list duplicated in GN build. 21 # Note: sources list duplicated in GN build.
42 'favicon/core/browser/favicon_client.h', 22 'favicon/core/favicon_client.h',
43 'favicon/core/browser/favicon_handler.cc', 23 'favicon/core/favicon_driver.h',
44 'favicon/core/browser/favicon_handler.h', 24 'favicon/core/favicon_handler.cc',
45 'favicon/core/browser/favicon_service.cc', 25 'favicon/core/favicon_handler.h',
46 'favicon/core/browser/favicon_service.h', 26 'favicon/core/favicon_service.cc',
47 'favicon/core/browser/favicon_tab_helper_observer.h', 27 'favicon/core/favicon_service.h',
28 'favicon/core/favicon_tab_helper_observer.h',
29 'favicon/core/favicon_url.cc',
30 'favicon/core/favicon_url.h',
48 ], 31 ],
49 'include_dirs': [ 32 'include_dirs': [
50 '..', 33 '..',
51 ], 34 ],
52 }, 35 },
53 ], 36 ],
54 } 37 }
OLDNEW
« no previous file with comments | « components/BUILD.gn ('k') | components/favicon/core/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698