Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1021143004: [New Multicolumn] Don't return the wrong flow thread from locateFlowThreadContainingBlock(). (Closed)

Created:
5 years, 9 months ago by mstensho (USE GERRIT)
Modified:
5 years, 9 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

[New Multicolumn] Don't return the wrong flow thread from locateFlowThreadContainingBlock(). LayoutListItem::updateMarkerLocationAndInvalidateWidth() does nasty things (inserts layout objects at "random" places in the tree during layout), so we need to temporarily reset the current flow thread in LayoutState, or we might end up locating the wrong one in LayoutObject::locateFlowThreadContainingBlock(). Need this until crbug.com/370461 gets fixed. This makes fast/lists/list-inside-columns-crash.html pass with the new multicol implementation, but since that test is still running with the old multicol implementation, I added a simplified tailored test that's actually run. BUG=334335, 460251 R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
A LayoutTests/fast/multicol/empty-list-item-as-nested-multicol.html View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/empty-list-item-as-nested-multicol-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutListItem.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutState.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
mstensho (USE GERRIT)
5 years, 9 months ago (2015-03-20 20:28:17 UTC) #1
Julien - ping for review
I think we should finish https://codereview.chromium.org/778003003 instead of this work-around. Dan can comment on the ...
5 years, 9 months ago (2015-03-23 15:20:49 UTC) #2
mstensho (USE GERRIT)
On 2015/03/23 15:20:49, Julien Chaffraix - PST wrote: > I think we should finish https://codereview.chromium.org/778003003 ...
5 years, 9 months ago (2015-03-23 22:51:50 UTC) #3
dsinclair
That change is going to take more time to land. I think landing this work ...
5 years, 9 months ago (2015-03-24 00:10:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021143004/1
5 years, 9 months ago (2015-03-24 08:38:43 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 10:03:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192423

Powered by Google App Engine
This is Rietveld 408576698