Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/

chrome/browser/metrics/chrome_metrics_service_client.h

Index: chrome/browser/metrics/chrome_metrics_service_client.h
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.h b/chrome/browser/metrics/chrome_metrics_service_client.h
index 7456d1dc15065b07d4d2322ff0671c26a8eeb1fc..77b55826a20cf7226c55fab487f7c1c16cc3d061 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.h
+++ b/chrome/browser/metrics/chrome_metrics_service_client.h
@@ -101,8 +101,8 @@ class ChromeMetricsServiceClient
       base::ProcessId process_id,
       content::ProcessType process_type,
       int profiling_phase,
-      base::TimeDelta phase_start,
-      base::TimeDelta phase_finish,
+      base::TimeTicks phase_start,
+      base::TimeTicks phase_finish,
       const metrics::ProfilerEvents& past_profiler_events) override;
   void FinishedReceivingProfilerData() override;
 
@@ -187,6 +187,9 @@ class ChromeMetricsServiceClient
 
   base::WeakPtrFactory<ChromeMetricsServiceClient> weak_ptr_factory_;

[Ilya Sherman, 2015/04/08 23:36:14]

nit: The WeakPtrFactory should always be the final member, so that it is
destroyed first.  This is a helpful pattern to follow in general, so that weak
pointers are always invalidated before other members are destroyed, and possibly
try to access those weak pointers.  In this case, there is no such risk; but
there's also no harm to following the pattern, and this is the sort of pattern
that is best to follow as uniformly as possible, so that readers don't need to
think about whether an exception is justified or not.

[vadimt, 2015/04/09 00:15:03]

Done.

 
+  // Time of this object's creation.
+  const base::TimeTicks start_time_;
+
   DISALLOW_COPY_AND_ASSIGN(ChromeMetricsServiceClient);
 };