Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/

chrome/browser/metrics/chrome_metrics_service_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_CLIENT_H_
 #define CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_CLIENT_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 83 matching lines @@
   // Called after GoogleUpdate init task has been completed that continues the
   // init task by loading profiler data.
   void OnInitTaskGotGoogleUpdateData();
 
   // TrackingSynchronizerObserver:
   void ReceivedProfilerData(
       const tracked_objects::ProcessDataPhaseSnapshot& process_data_phase,
       base::ProcessId process_id,
       content::ProcessType process_type,
       int profiling_phase,
-      base::TimeDelta phase_start,
-      base::TimeDelta phase_finish,
+      base::TimeTicks phase_start,
+      base::TimeTicks phase_finish,
       const metrics::ProfilerEvents& past_profiler_events) override;
   void FinishedReceivingProfilerData() override;
 
   // Callbacks for various stages of final log info collection. Do not call
   // these directly.
   void OnMemoryDetailCollectionDone();
   void OnHistogramSynchronizationDone();
 
   // Records metrics about the switches present on the command line.
   void RecordCommandLineMetrics();
@@ skipping 62 matching lines @@
   base::Closure finished_gathering_initial_metrics_callback_;
 
   // The MemoryGrowthTracker instance that tracks memory usage growth in
   // MemoryDetails.
   MemoryGrowthTracker memory_growth_tracker_;
 
   // Callback to determine whether or not a cellular network is currently being
   // used.
   base::Callback<void(bool*)> cellular_callback_;
 
   base::WeakPtrFactory<ChromeMetricsServiceClient> weak_ptr_factory_;

[Ilya Sherman, 2015/04/08 23:36:14]

nit: The WeakPtrFactory should always be the final member, so that it is
destroyed first.  This is a helpful pattern to follow in general, so that weak
pointers are always invalidated before other members are destroyed, and possibly
try to access those weak pointers.  In this case, there is no such risk; but
there's also no harm to following the pattern, and this is the sort of pattern
that is best to follow as uniformly as possible, so that readers don't need to
think about whether an exception is justified or not.

[vadimt, 2015/04/09 00:15:03]

Done.

 
+  // Time of this object's creation.
+  const base::TimeTicks start_time_;
+
   DISALLOW_COPY_AND_ASSIGN(ChromeMetricsServiceClient);
 };
 
 #endif  // CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_CLIENT_H_