Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: Source/core/inspector/InspectorPageAgent.cpp

Issue 102103002: Have HashMap<KeyType, AtomicString>::get() return a const reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorPageAgent.cpp
diff --git a/Source/core/inspector/InspectorPageAgent.cpp b/Source/core/inspector/InspectorPageAgent.cpp
index fcdb8545689f440cd8d395d91af2d7568f04241d..cd590949de8ac96380fb6784b9c6b9f8906b1723 100644
--- a/Source/core/inspector/InspectorPageAgent.cpp
+++ b/Source/core/inspector/InspectorPageAgent.cpp
@@ -898,19 +898,19 @@ Frame* InspectorPageAgent::assertFrame(ErrorString* errorString, const String& f
return frame;
}
-String InspectorPageAgent::resourceSourceMapURL(const String& url)
+const AtomicString& InspectorPageAgent::resourceSourceMapURL(const String& url)
{
- DEFINE_STATIC_LOCAL(String, sourceMapHttpHeader, ("SourceMap"));
- DEFINE_STATIC_LOCAL(String, deprecatedSourceMapHttpHeader, ("X-SourceMap"));
+ DEFINE_STATIC_LOCAL(const AtomicString, sourceMapHttpHeader, ("SourceMap"));
tkent 2013/12/04 01:01:00 Should have ConstructFromLiteral argument.
Inactive 2013/12/04 14:11:26 Done.
+ DEFINE_STATIC_LOCAL(const AtomicString, deprecatedSourceMapHttpHeader, ("X-SourceMap"));
tkent 2013/12/04 01:01:00 Ditto.
Inactive 2013/12/04 14:11:26 Done.
if (url.isEmpty())
- return String();
+ return nullAtom;
Frame* frame = mainFrame();
if (!frame)
- return String();
+ return nullAtom;
Resource* resource = cachedResource(frame, KURL(ParsedURLString, url));
if (!resource)
- return String();
- String deprecatedHeaderSourceMapURL = resource->response().httpHeaderField(deprecatedSourceMapHttpHeader);
+ return nullAtom;
+ const AtomicString& deprecatedHeaderSourceMapURL = resource->response().httpHeaderField(deprecatedSourceMapHttpHeader);
if (!deprecatedHeaderSourceMapURL.isEmpty()) {
// FIXME: add deprecated console message here.
return deprecatedHeaderSourceMapURL;

Powered by Google App Engine
This is Rietveld 408576698