Source/core/html/parser/XSSAuditor.cpp - Issue 102103002: Have HashMap<KeyType, AtomicString>::get() return a const reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/parser/XSSAuditor.cpp

Issue 102103002: Have HashMap<KeyType, AtomicString>::get() return a const reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/html/forms/FormController.cpp ('k') | Source/core/inspector/InspectorPageAgent.h » ('j') | Source/core/inspector/InspectorPageAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/parser/XSSAuditor.cpp

diff --git a/Source/core/html/parser/XSSAuditor.cpp b/Source/core/html/parser/XSSAuditor.cpp

index 4c12a0b89f11cb40cc1d1bfcfc379500f229f7ce..a639578160db4f8d193a61294d8d86a541921330 100644

--- a/Source/core/html/parser/XSSAuditor.cpp

+++ b/Source/core/html/parser/XSSAuditor.cpp

@@ -263,8 +263,8 @@ void XSSAuditor::init(Document* document, XSSAuditorDelegate* auditorDelegate)

String httpBodyAsString;

if (DocumentLoader* documentLoader = document->frame()->loader().documentLoader()) {

- DEFINE_STATIC_LOCAL(String, XSSProtectionHeader, ("X-XSS-Protection"));

- String headerValue = documentLoader->response().httpHeaderField(XSSProtectionHeader);

+ DEFINE_STATIC_LOCAL(const AtomicString, XSSProtectionHeader, ("X-XSS-Protection"));

tkent 2013/12/04 01:01:00 should have ConstructFromLiteral argument.

Inactive 2013/12/04 14:11:26 Done.

+ const AtomicString& headerValue = documentLoader->response().httpHeaderField(XSSProtectionHeader);

String errorDetails;

unsigned errorPosition = 0;

String reportURL;

« no previous file with comments | « Source/core/html/forms/FormController.cpp ('k') | Source/core/inspector/InspectorPageAgent.h » ('j') | Source/core/inspector/InspectorPageAgent.cpp » ('J')