Source/core/fetch/ResourceFetcher.cpp - Issue 102103002: Have HashMap<KeyType, AtomicString>::get() return a const reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fetch/ResourceFetcher.cpp

Issue 102103002: Have HashMap<KeyType, AtomicString>::get() return a const reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/fetch/ResourceFetcher.cpp

diff --git a/Source/core/fetch/ResourceFetcher.cpp b/Source/core/fetch/ResourceFetcher.cpp

index 4cb4aa5b3785eaf2b2fc695d92e79c2881f20c7d..b031b43eeba0c92c013486cd9bf1efeaaf126ba9 100644

--- a/Source/core/fetch/ResourceFetcher.cpp

+++ b/Source/core/fetch/ResourceFetcher.cpp

@@ -738,8 +738,8 @@ ResourcePtr<Resource> ResourceFetcher::revalidateResource(const FetchRequest& re

ResourceRequest revalidatingRequest(resource->resourceRequest());

addAdditionalRequestHeaders(revalidatingRequest, resource->type());

- const String& lastModified = resource->response().httpHeaderField("Last-Modified");

- const String& eTag = resource->response().httpHeaderField("ETag");

+ const AtomicString& lastModified = resource->response().httpHeaderField("Last-Modified");

+ const AtomicString& eTag = resource->response().httpHeaderField("ETag");

if (!lastModified.isEmpty() || !eTag.isEmpty()) {

ASSERT(context().cachePolicy(resource->type()) != CachePolicyReload);

if (context().cachePolicy(resource->type()) == CachePolicyRevalidate)

« no previous file with comments | « Source/core/fetch/CrossOriginAccessControl.cpp ('k') | Source/core/html/HTMLElement.h » ('j') | Source/core/html/parser/XSSAuditor.cpp » ('J')