Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1020913002: Cleanup ChromeHistoryClientFactory (Closed)

Created:
5 years, 9 months ago by sdefresne
Modified:
5 years, 9 months ago
Reviewers:
jif
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup ChromeHistoryClientFactory Change interface of GetForProfile() to return an history::HistoryClient* instead of a ChromeHistoryClient* since no-one depends on the more typed return value. Remove unused GetForProfileWithoutCreating() method which is no longer used (and the corresponding comment). BUG=None Committed: https://crrev.com/68471b7bef6e35835e343a0e9605ed45481aad72 Cr-Commit-Position: refs/heads/master@{#321589}

Patch Set 1 #

Patch Set 2 : Fix android compilation of unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M chrome/browser/history/android/android_provider_backend_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/chrome_history_client_factory.h View 1 chunk +5 lines, -8 lines 0 comments Download
M chrome/browser/history/chrome_history_client_factory.cc View 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sdefresne
PTAL
5 years, 9 months ago (2015-03-19 17:40:32 UTC) #2
jif
lgtm
5 years, 9 months ago (2015-03-19 18:04:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020913002/1
5 years, 9 months ago (2015-03-19 18:20:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020913002/20001
5 years, 9 months ago (2015-03-20 16:54:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 17:34:19 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 17:35:26 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/68471b7bef6e35835e343a0e9605ed45481aad72
Cr-Commit-Position: refs/heads/master@{#321589}

Powered by Google App Engine
This is Rietveld 408576698