Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/browser/history/chrome_history_client_factory.h

Issue 1020913002: Cleanup ChromeHistoryClientFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix android compilation of unit tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_ 5 #ifndef CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_
6 #define CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_ 6 #define CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_
7 7
8 #include "components/keyed_service/content/browser_context_keyed_service_factory .h" 8 #include "components/keyed_service/content/browser_context_keyed_service_factory .h"
9 9
10 template <typename T> 10 template <typename T>
11 struct DefaultSingletonTraits; 11 struct DefaultSingletonTraits;
12 12
13 class ChromeHistoryClient;
14 class Profile; 13 class Profile;
15 14
15 namespace history {
16 class HistoryClient;
17 }
18
16 // Singleton that owns all ChromeHistoryClients and associates them with 19 // Singleton that owns all ChromeHistoryClients and associates them with
17 // Profiles. 20 // Profiles.
18 class ChromeHistoryClientFactory : public BrowserContextKeyedServiceFactory { 21 class ChromeHistoryClientFactory : public BrowserContextKeyedServiceFactory {
19 public: 22 public:
20 static ChromeHistoryClient* GetForProfile(Profile* profile); 23 static history::HistoryClient* GetForProfile(Profile* profile);
21
22 // TODO(sdefresne): remove this once ChromeHistoryClient is no longer an
23 // HistoryServiceObserver and can follow the regular shutdown even during
24 // tests.
25 static ChromeHistoryClient* GetForProfileWithoutCreating(Profile* profile);
26
27 static ChromeHistoryClientFactory* GetInstance(); 24 static ChromeHistoryClientFactory* GetInstance();
28 25
29 private: 26 private:
30 friend struct DefaultSingletonTraits<ChromeHistoryClientFactory>; 27 friend struct DefaultSingletonTraits<ChromeHistoryClientFactory>;
31 28
32 ChromeHistoryClientFactory(); 29 ChromeHistoryClientFactory();
33 ~ChromeHistoryClientFactory() override; 30 ~ChromeHistoryClientFactory() override;
34 31
35 // BrowserContextKeyedServiceFactory: 32 // BrowserContextKeyedServiceFactory:
36 KeyedService* BuildServiceInstanceFor( 33 KeyedService* BuildServiceInstanceFor(
37 content::BrowserContext* context) const override; 34 content::BrowserContext* context) const override;
38 content::BrowserContext* GetBrowserContextToUse( 35 content::BrowserContext* GetBrowserContextToUse(
39 content::BrowserContext* context) const override; 36 content::BrowserContext* context) const override;
40 bool ServiceIsNULLWhileTesting() const override; 37 bool ServiceIsNULLWhileTesting() const override;
41 }; 38 };
42 39
43 #endif // CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_ 40 #endif // CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698