Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1020853015: [telemetry] Add newlines to the end of all files that are missing it. (Closed)

Created:
5 years, 9 months ago by dtu
Modified:
5 years, 9 months ago
CC:
chromium-reviews, tfarina, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Add newlines to the end of all files that are missing it. I'm trying to use Python's tokenize library, but it has a bug with this case. (Verified in Python 2.7.9.) Soooo just eliminate all instances. Also adjust some long comments. The style guide rule is, "within comments, put long URLs on their own line if necessary." BUG=449308 TEST=None. Committed: https://crrev.com/cbac7afac855f18acfe15dd83fade52f67ff1c77 Cr-Commit-Position: refs/heads/master@{#322691}

Patch Set 1 #

Messages

Total messages: 12 (4 generated)
dtu
5 years, 9 months ago (2015-03-25 20:04:31 UTC) #2
aiolos (Not reviewing)
On 2015/03/25 20:04:31, dtu wrote: lgtm
5 years, 9 months ago (2015-03-25 20:07:34 UTC) #3
nednguyen
On 2015/03/25 20:07:34, aiolos wrote: > On 2015/03/25 20:04:31, dtu wrote: > > lgtm lgtm
5 years, 9 months ago (2015-03-25 20:11:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020853015/1
5 years, 9 months ago (2015-03-25 20:13:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/51887)
5 years, 9 months ago (2015-03-25 20:22:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020853015/1
5 years, 9 months ago (2015-03-28 00:37:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-28 01:36:40 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-28 01:37:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbac7afac855f18acfe15dd83fade52f67ff1c77
Cr-Commit-Position: refs/heads/master@{#322691}

Powered by Google App Engine
This is Rietveld 408576698