tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py - Issue 1020853015: [telemetry] Add newlines to the end of all files that are missing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py

Issue 1020853015: [telemetry] Add newlines to the end of all files that are missing it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py ('k') | tools/telemetry/telemetry/core/platform/trybot_device.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py

diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py b/tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py

index c4ecd8547815e6f3c9c536a3935c2b9841e67b70..b97d81f2237bf969acc7fdb1c41703a397eb7218 100644

--- a/tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py

+++ b/tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py

@@ -25,8 +25,7 @@ def _JoulesToMilliwattHours(value_joules):

def _IsSandyBridgeOrLater(vendor, family, model):

# Model numbers from:

- # https://software.intel.com/en-us/articles/intel-architecture-and- \

- # processor-identification-with-cpuid-model-and-family-numbers

+ # https://software.intel.com/en-us/articles/intel-architecture-and-processor-identification-with-cpuid-model-and-family-numbers

# http://www.speedtraq.com

return ('Intel' in vendor and family == 6 and

(model in (0x2A, 0x2D) or model >= 0x30))