Remove CanRetainOtherContext since embedded objects are now weak.

src/ic/stub-cache.cc

Index: src/ic/stub-cache.cc
diff --git a/src/ic/stub-cache.cc b/src/ic/stub-cache.cc
index 35a4acf8cc3a73bf50e1f665cba9a8baa230b15b..0c17a3b908d6a6bd18623b56206dbd88dd8de02f 100644
--- a/src/ic/stub-cache.cc
+++ b/src/ic/stub-cache.cc
@@ -117,8 +117,7 @@ void StubCache::CollectMatchingMaps(SmallMapList* types, Handle<Name> name,
       if (map == NULL) continue;
 
       int offset = PrimaryOffset(*name, flags, map);
-      if (entry(primary_, offset) == &primary_[i] &&
-          !TypeFeedbackOracle::CanRetainOtherContext(map, *native_context)) {
+      if (entry(primary_, offset) == &primary_[i]) {

[Erik Corry, 2015/03/26 10:09:43]

Apart from avoiding leaks this also served to remove maps from other contexts
that the context-specific optimized code would not be expected to see. As such
it could make code monomorphic where it would otherwise be polymorphic.  Perhaps
it just needs renaming?

[Toon Verwaest, 2015/03/26 10:19:06]

That's true, but I presume we don't need the entire recursive mechanism though.
That's what I was trying to avoid, in addition to fixing the memory leak due to
the fact that we still inlined cross-context despite this method.

         types->AddMapIfMissing(Handle<Map>(map), zone);
       }
     }
@@ -136,8 +135,7 @@ void StubCache::CollectMatchingMaps(SmallMapList* types, Handle<Name> name,
 
       // Lookup in secondary table and add matches.
       int offset = SecondaryOffset(*name, flags, primary_offset);
-      if (entry(secondary_, offset) == &secondary_[i] &&
-          !TypeFeedbackOracle::CanRetainOtherContext(map, *native_context)) {
+      if (entry(secondary_, offset) == &secondary_[i]) {
         types->AddMapIfMissing(Handle<Map>(map), zone);
       }
     }