Remove CanRetainOtherContext since embedded objects are now weak.

src/ic/stub-cache.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/base/bits.h"
 #include "src/ic/stub-cache.h"
 #include "src/type-info.h"
 
@@ skipping 99 matching lines @@
                                     Handle<Context> native_context,
                                     Zone* zone) {
   for (int i = 0; i < kPrimaryTableSize; i++) {
     if (primary_[i].key == *name) {
       Map* map = primary_[i].map;
       // Map can be NULL, if the stub is constant function call
       // with a primitive receiver.
       if (map == NULL) continue;
 
       int offset = PrimaryOffset(*name, flags, map);
-      if (entry(primary_, offset) == &primary_[i] &&
-          !TypeFeedbackOracle::CanRetainOtherContext(map, *native_context)) {
+      if (entry(primary_, offset) == &primary_[i]) {

[Erik Corry, 2015/03/26 10:09:43]

Apart from avoiding leaks this also served to remove maps from other contexts
that the context-specific optimized code would not be expected to see. As such
it could make code monomorphic where it would otherwise be polymorphic.  Perhaps
it just needs renaming?

[Toon Verwaest, 2015/03/26 10:19:06]

That's true, but I presume we don't need the entire recursive mechanism though.
That's what I was trying to avoid, in addition to fixing the memory leak due to
the fact that we still inlined cross-context despite this method.

         types->AddMapIfMissing(Handle<Map>(map), zone);
       }
     }
   }
 
   for (int i = 0; i < kSecondaryTableSize; i++) {
     if (secondary_[i].key == *name) {
       Map* map = secondary_[i].map;
       // Map can be NULL, if the stub is constant function call
       // with a primitive receiver.
       if (map == NULL) continue;
 
       // Lookup in primary table and skip duplicates.
       int primary_offset = PrimaryOffset(*name, flags, map);
 
       // Lookup in secondary table and add matches.
       int offset = SecondaryOffset(*name, flags, primary_offset);
-      if (entry(secondary_, offset) == &secondary_[i] &&
-          !TypeFeedbackOracle::CanRetainOtherContext(map, *native_context)) {
+      if (entry(secondary_, offset) == &secondary_[i]) {
         types->AddMapIfMissing(Handle<Map>(map), zone);
       }
     }
   }
 }
 }
 }  // namespace v8::internal