tools/perf/profile_creators/profile_extender.py - Issue 1020703002: Telemetry: Remove the class ProfileCreator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/profile_creators/profile_extender.py

Issue 1020703002: Telemetry: Remove the class ProfileCreator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/profile_creators/profile_extender.py

diff --git a/tools/perf/profile_creators/profile_creator.py b/tools/perf/profile_creators/profile_extender.py

similarity index 92%

rename from tools/perf/profile_creators/profile_creator.py

rename to tools/perf/profile_creators/profile_extender.py

index c67e5bdae062c889d570f4405619d9b77e49af77..fe0ed3aa6ffd378efadb6cbd92989f102e967ce8 100644

--- a/tools/perf/profile_creators/profile_creator.py

+++ b/tools/perf/profile_creators/profile_extender.py

@@ -2,11 +2,11 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-class ProfileCreator(object):

+class ProfileExtender(object):

"""Abstract base class for an object that constructs a Chrome profile."""

def Run(self, options):

- """Creates the profile.

+ """Creates or extends the profile.

|options| is an instance of BrowserFinderOptions. When subclass

implementations of this method inevitably attempt to find and launch a