Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1020673002: Make STLDeleteValues delete behind the iterator. (Closed)

Created:
5 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make STLDeleteValues delete behind the iterator. Make STLDeleteValues do like STLDeleteElements and increment the iterator before deleting the value. This protects against modifications to the container that may invalidate the current iterator. STLDeleteContainerPairSecondPointers already provides this ability. Committed: https://crrev.com/c2af413b751be6f483351ec9dfb4b36e2b21e40e Cr-Commit-Position: refs/heads/master@{#321271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M base/stl_util.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
thestig@, please take a look.
5 years, 9 months ago (2015-03-18 23:27:55 UTC) #2
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-18 23:31:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020673002/1
5 years, 9 months ago (2015-03-18 23:42:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 02:28:50 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 02:30:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2af413b751be6f483351ec9dfb4b36e2b21e40e
Cr-Commit-Position: refs/heads/master@{#321271}

Powered by Google App Engine
This is Rietveld 408576698