base/stl_util.h - Issue 1020673002: Make STLDeleteValues delete behind the iterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/stl_util.h

Issue 1020673002: Make STLDeleteValues delete behind the iterator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/stl_util.h

diff --git a/base/stl_util.h b/base/stl_util.h

index 3602df0377ade5e461c73aad16f672743050b98d..89a53b070ef515cf81d584098e7aace8ed2ba201 100644

--- a/base/stl_util.h

+++ b/base/stl_util.h

@@ -148,8 +148,7 @@ template <class T>

void STLDeleteValues(T* container) {

if (!container)

return;

- for (typename T::iterator i(container->begin()); i != container->end(); ++i)

- delete i->second;

+ STLDeleteContainerPairSecondPointers(container->begin(), container->end());

container->clear();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »