Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1020073002: tools/gn: sync documentation with reality (Closed)

Created:
5 years, 9 months ago by mdempsky
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/gn: sync documentation with reality Compiler tool definitions use {{source}} and {{output}} to specify the source and output files, not $in and $out. Also fix some typos and spurious commas. Committed: https://crrev.com/36d057d7f2eb9e97c693e9b241f9880212768e7e Cr-Commit-Position: refs/heads/master@{#321605}

Patch Set 1 #

Patch Set 2 : Another typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M tools/gn/function_toolchain.cc View 1 5 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mdempsky
5 years, 9 months ago (2015-03-19 23:17:15 UTC) #2
mdempsky
5 years, 9 months ago (2015-03-20 18:11:28 UTC) #4
brettw
lgtm
5 years, 9 months ago (2015-03-20 18:14:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020073002/20001
5 years, 9 months ago (2015-03-20 18:16:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 18:41:29 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 18:46:17 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/36d057d7f2eb9e97c693e9b241f9880212768e7e
Cr-Commit-Position: refs/heads/master@{#321605}

Powered by Google App Engine
This is Rietveld 408576698