Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: tools/gn/function_toolchain.cc

Issue 1020073002: tools/gn: sync documentation with reality (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another typo Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_toolchain.cc
diff --git a/tools/gn/function_toolchain.cc b/tools/gn/function_toolchain.cc
index cebe2d290b196084b4414bc70effc29d16f8b2c4..9224f43d362361e8fec3ebacfc0173509af4eea7 100644
--- a/tools/gn/function_toolchain.cc
+++ b/tools/gn/function_toolchain.cc
@@ -266,7 +266,7 @@ const char kToolchain_Help[] =
" concurrent_links = 8\n"
"\n"
" tool(\"cc\") {\n"
- " command = \"gcc $in\"\n"
+ " command = \"gcc {{source}}\"\n"
" ...\n"
" }\n"
"\n"
@@ -553,7 +553,7 @@ const char kTool_Help[] =
" will be included for targets in other toolchains.\n"
"\n"
" {{output}}\n"
- " The relative path and name of the output)((s) of the current\n"
+ " The relative path and name of the output(s) of the current\n"
" build step. If there is more than one output, this will expand\n"
" to a list of all of them.\n"
" Example: \"out/base/my_file.o\"\n"
@@ -631,7 +631,7 @@ const char kTool_Help[] =
" {{ldflags}}\n"
" Expands to the processed set of ldflags and library search paths\n"
" specified for the target.\n"
- " Example: \"-m64, -fPIC -pthread -L/usr/local/mylib\"\n"
+ " Example: \"-m64 -fPIC -pthread -L/usr/local/mylib\"\n"
"\n"
" {{libs}}\n"
" Expands to the list of system libraries to link to. Each will\n"
@@ -688,10 +688,10 @@ const char kTool_Help[] =
"{{output_extension}}.TOC\",\n"
" ]\n"
" link_output =\n"
- " \"{{root_out_dir}}/{{target_output_name}}{{output_extension}}\",\n"
+ " \"{{root_out_dir}}/{{target_output_name}}{{output_extension}}\"\n"
" depend_output =\n"
" \"{{root_out_dir}}/{{target_output_name}}"
- "{{output_extension}}.TOC\",\n"
+ "{{output_extension}}.TOC\"\n"
" restat = true\n"
" }\n"
"\n"
@@ -703,14 +703,14 @@ const char kTool_Help[] =
" lib_dir_prefix = \"-L\"\n"
"\n"
" tool(\"cc\") {\n"
- " command = \"gcc \\$in -o \\$out\"\n"
- " outputs = [ \"{{source_out_dir}}/{{source_name_part}}.o\"\n"
- " description = \"GCC \\$in\"\n"
+ " command = \"gcc {{source}} -o {{output}}\"\n"
+ " outputs = [ \"{{source_out_dir}}/{{source_name_part}}.o\" ]\n"
+ " description = \"GCC {{source}}\"\n"
" }\n"
" tool(\"cxx\") {\n"
- " command = \"g++ \\$in -o \\$out\"\n"
- " outputs = [ \"{{source_out_dir}}/{{source_name_part}}.o\"\n"
- " description = \"G++ \\$in\"\n"
+ " command = \"g++ {{source}} -o {{output}}\"\n"
+ " outputs = [ \"{{source_out_dir}}/{{source_name_part}}.o\" ]\n"
+ " description = \"G++ {{source}}\"\n"
" }\n"
" }\n";
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698