Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1019943002: Check for NULL PasswordFormManager* in ManagePasswordsUIController::SavePasswordInternal(). (Closed)

Created:
5 years, 9 months ago by vasilii
Modified:
5 years, 9 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check for NULL PasswordFormManager* in ManagePasswordsUIController::SavePasswordInternal(). BUG=468474 Committed: https://crrev.com/363750d17c11bf953e19b4da4aeb1c12f30f997f Cr-Commit-Position: refs/heads/master@{#321408}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed the nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/ui/passwords/manage_passwords_ui_controller.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
vasilii
Hi Vaclav, please review the CL.
5 years, 9 months ago (2015-03-19 18:10:23 UTC) #2
vabr (Chromium)
LGTM with a simple nit. Thanks! Vaclav https://codereview.chromium.org/1019943002/diff/1/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc File chrome/browser/ui/passwords/manage_passwords_ui_controller.cc (right): https://codereview.chromium.org/1019943002/diff/1/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc#newcode222 chrome/browser/ui/passwords/manage_passwords_ui_controller.cc:222: // If ...
5 years, 9 months ago (2015-03-19 18:19:10 UTC) #3
vasilii
https://codereview.chromium.org/1019943002/diff/1/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc File chrome/browser/ui/passwords/manage_passwords_ui_controller.cc (right): https://codereview.chromium.org/1019943002/diff/1/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc#newcode222 chrome/browser/ui/passwords/manage_passwords_ui_controller.cc:222: // If this is a cause of crbug/468474 then ...
5 years, 9 months ago (2015-03-19 18:23:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019943002/20001
5 years, 9 months ago (2015-03-19 18:23:47 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 19:34:15 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 19:34:49 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/363750d17c11bf953e19b4da4aeb1c12f30f997f
Cr-Commit-Position: refs/heads/master@{#321408}

Powered by Google App Engine
This is Rietveld 408576698