Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 1019943002: Check for NULL PasswordFormManager* in ManagePasswordsUIController::SavePasswordInternal(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed the nit Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
index cba75401d0cda884cf6daacb29abf59e68e60791..bbc7c14eee211c763cc3dfb86ee12600ae46ff0d 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
@@ -218,8 +218,11 @@ void ManagePasswordsUIController::ChooseCredential(
void ManagePasswordsUIController::SavePasswordInternal() {
password_manager::PasswordFormManager* form_manager =
passwords_data_.form_manager();
- DCHECK(form_manager);
- form_manager->Save();
+ // TODO(vasilii): it's not OK to call SavePassword() when |form_manager| is 0.
+ // If this is a cause of http://crbug.com/468474 then we should hide the
+ // bubble when ManagePasswordsUIController changes its internal state.
+ if (form_manager)
+ form_manager->Save();
}
void ManagePasswordsUIController::NeverSavePassword() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698