Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1019913002: Revert of Add RoutingIDIssuer to help track routing id issues. (Closed)

Created:
5 years, 9 months ago by lfg
Modified:
5 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, jam, nektar+watch_chromium.org, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add RoutingIDIssuer to help track routing id issues. (patchset #4 id:60001 of https://codereview.chromium.org/999193003/) Reason for revert: We've already collected enough data to triage this bug. Original issue's description: > This is a re-land of https://codereview.chromium.org/643733002. > > This CL adds a RoutingIDIssuer that verifies that the routing IDs are being sent to the correct process. > > BUG=464633 > TBR=sky@chromium.org > > Committed: https://crrev.com/5ae65efdfd51de794fb544195fad271dd90ff0b1 > Cr-Commit-Position: refs/heads/master@{#320207} TBR=nasko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464633 Committed: https://crrev.com/052af418cf20a22c485825cd4e2628c4925b5e64 Cr-Commit-Position: refs/heads/master@{#321380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -223 lines) Patch
M chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/accessibility/site_per_process_accessibility_browsertest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.h View 4 chunks +3 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.cc View 3 chunks +1 line, -7 lines 0 comments Download
D content/browser/renderer_host/routing_id_issuer.h View 1 chunk +0 lines, -44 lines 0 comments Download
D content/browser/renderer_host/routing_id_issuer.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D content/browser/renderer_host/routing_id_issuer_unittest.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
D content/public/test/routing_id_mangling_disabler.h View 1 chunk +0 lines, -20 lines 0 comments Download
D content/public/test/routing_id_mangling_disabler.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M content/renderer/dom_serializer_browsertest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/resource_fetcher_browsertest.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
lfg
Created Revert of Add RoutingIDIssuer to help track routing id issues.
5 years, 9 months ago (2015-03-19 16:48:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019913002/1
5 years, 9 months ago (2015-03-19 16:49:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 16:50:01 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 16:50:54 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/052af418cf20a22c485825cd4e2628c4925b5e64
Cr-Commit-Position: refs/heads/master@{#321380}

Powered by Google App Engine
This is Rietveld 408576698