chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc - Issue 1019913002: Revert of Add RoutingIDIssuer to help track routing id issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

Issue 1019913002: Revert of Add RoutingIDIssuer to help track routing id issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc ('k') | content/browser/accessibility/site_per_process_accessibility_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

diff --git a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

index 6392c9014ebb80972a83a24b71c0c93b9ce1c76c..3d1814fcc771c3ffa3103015731859001a7a0d85 100644

--- a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

+++ b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

@@ -29,7 +29,6 @@

#include "content/public/browser/web_contents.h"

#include "content/public/renderer/render_view.h"

#include "content/public/test/browser_test_utils.h"

-#include "content/public/test/routing_id_mangling_disabler.h"

#include "content/public/test/test_utils.h"

#include "net/dns/mock_host_resolver.h"

#include "net/test/embedded_test_server/embedded_test_server.h"

@@ -180,7 +179,6 @@

// Any urls not in this map are served a 404 error.

std::map<std::string, std::string> responses_;

- content::RoutingIDManglingDisabler mangling_disabler_;

scoped_ptr<net::test_server::EmbeddedTestServer> embedded_test_server_;

MockFeatureExtractorClock clock_;

scoped_ptr<PhishingDOMFeatureExtractor> extractor_;