Chromium Code Reviews
DescriptionRevert of Add second batch JS benchmark and code generator (patchset #5 id:60001 of https://codereview.chromium.org/1000203002/)
Reason for revert:
Breaks check_licenses on linux: https://build.chromium.org/p/chromium/builders/Linux/builds/59754/steps/check_licenses/logs/stdio
Notice: This was also caught by the trybot. Please don't commit manually - use the CQ instead.
Original issue's description:
> Add second batch JS benchmark and code generator
>
> This patch adds a "Second batch JS" benchmark and a code generator for
> creating synthetic Javascript content for the different variants of the
> benchmark.
>
> The benchmark flow is:
>
> 1. Load an initial page quickly. We also start a continuous animation
> which gauges the responsiveness of the main thread.
> 2. Start loading Javascript asynchronously.
> 3. When the loading completes, wait 1 second and click on a button
> which causes about 5% of the Javascript to execute.
>
> The aim is to keep the page responsive during loading and minimize the
> latency of the click handler. There are three variants with a small (15K),
> medium (150K) and large (1.2M) amount of Javascript.
>
> The generated Javascript consists of half top-level closures, half top-level
> functions, each of which calls a varying number of inner functions to
> perform arithmetic.
>
> Note that currently the benchmark only measures the responsiveness of the
> click handler, but eventually it will be able to track this over the entire
> interaction flow (crbug.com/460206).
>
> BUG=428350
> R=rmcilroy@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/b0a90f4b6c81fc65dd0c57ebc00b0ba6fe784b22
TBR=rmcilroy@chromium.org,skyostil@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=428350
Committed: https://crrev.com/aba26bbc72b818a0afa6461dfdcfe8c86558ce5a
Cr-Commit-Position: refs/heads/master@{#321342}
Patch Set 1 #
Created: 5 years, 9 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||