Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1019833002: Revert of Add second batch JS benchmark and code generator (Closed)

Created:
5 years, 9 months ago by kjellander_chromium
Modified:
5 years, 9 months ago
Reviewers:
Sami, rmcilroy
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add second batch JS benchmark and code generator (patchset #5 id:60001 of https://codereview.chromium.org/1000203002/) Reason for revert: Breaks check_licenses on linux: https://build.chromium.org/p/chromium/builders/Linux/builds/59754/steps/check_licenses/logs/stdio Notice: This was also caught by the trybot. Please don't commit manually - use the CQ instead. Original issue's description: > Add second batch JS benchmark and code generator > > This patch adds a "Second batch JS" benchmark and a code generator for > creating synthetic Javascript content for the different variants of the > benchmark. > > The benchmark flow is: > > 1. Load an initial page quickly. We also start a continuous animation > which gauges the responsiveness of the main thread. > 2. Start loading Javascript asynchronously. > 3. When the loading completes, wait 1 second and click on a button > which causes about 5% of the Javascript to execute. > > The aim is to keep the page responsive during loading and minimize the > latency of the click handler. There are three variants with a small (15K), > medium (150K) and large (1.2M) amount of Javascript. > > The generated Javascript consists of half top-level closures, half top-level > functions, each of which calls a varying number of inner functions to > perform arithmetic. > > Note that currently the benchmark only measures the responsiveness of the > click handler, but eventually it will be able to track this over the entire > interaction flow (crbug.com/460206). > > BUG=428350 > R=rmcilroy@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/b0a90f4b6c81fc65dd0c57ebc00b0ba6fe784b22 TBR=rmcilroy@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=428350 Committed: https://crrev.com/aba26bbc72b818a0afa6461dfdcfe8c86558ce5a Cr-Commit-Position: refs/heads/master@{#321342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -364 lines) Patch
M tools/perf/page_sets/tough_scheduling_cases.py View 4 chunks +3 lines, -36 lines 0 comments Download
D tools/perf/page_sets/tough_scheduling_cases/generate_second_batch_js.sh View 1 chunk +0 lines, -38 lines 0 comments Download
D tools/perf/page_sets/tough_scheduling_cases/second_batch_js.html View 1 chunk +0 lines, -117 lines 0 comments Download
D tools/perf/page_sets/tough_scheduling_cases/second_batch_js_generator.py View 1 chunk +0 lines, -169 lines 0 comments Download
D tools/perf/page_sets/tough_scheduling_cases/second_batch_js_light.min.js View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/perf/page_sets/tough_scheduling_cases/second_batch_js_medium.min.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kjellander_chromium
Created Revert of Add second batch JS benchmark and code generator
5 years, 9 months ago (2015-03-19 12:53:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019833002/1
5 years, 9 months ago (2015-03-19 12:53:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 12:54:03 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 12:55:09 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aba26bbc72b818a0afa6461dfdcfe8c86558ce5a
Cr-Commit-Position: refs/heads/master@{#321342}

Powered by Google App Engine
This is Rietveld 408576698