Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: tools/perf/page_sets/tough_scheduling_cases.py

Issue 1019833002: Revert of Add second batch JS benchmark and code generator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/tough_scheduling_cases/generate_second_batch_js.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/tough_scheduling_cases.py
diff --git a/tools/perf/page_sets/tough_scheduling_cases.py b/tools/perf/page_sets/tough_scheduling_cases.py
index b30b8ee344b1accfc16ff1b3f3206d07499f7cf5..9da9afc1786a1516efeb16972d5ae3e98af799bf 100644
--- a/tools/perf/page_sets/tough_scheduling_cases.py
+++ b/tools/perf/page_sets/tough_scheduling_cases.py
@@ -369,35 +369,6 @@
interaction.End()
-class SecondBatchJsPage(ToughSchedulingCasesPage):
-
- """Why: For testing dynamically loading a large batch of Javascript and
- running a part of it in response to user input.
- """
-
- def __init__(self, page_set, variant='medium'):
- super(SecondBatchJsPage, self).__init__(
- url='file://tough_scheduling_cases/second_batch_js.html?%s' % variant,
- page_set=page_set)
-
- def RunPageInteractions(self, action_runner):
- # Do a dummy tap to warm up the synthetic tap code path.
- action_runner.TapElement(selector='div[id="spinner"]')
- # Begin the action immediately because we want the page to update smoothly
- # even while resources are being loaded.
- action_runner.WaitForJavaScriptCondition('window.__ready !== undefined')
-
- interaction = action_runner.BeginGestureInteraction('LoadAction')
- action_runner.ExecuteJavaScript('kickOffLoading()')
- action_runner.WaitForJavaScriptCondition('window.__ready')
- # Click one second after the resources have finished loading.
- action_runner.Wait(1)
- action_runner.TapElement(selector='input[id="run"]')
- # Wait for the test to complete.
- action_runner.WaitForJavaScriptCondition('window.__finished')
- interaction.End()
-
-
class ToughSchedulingCasesPageSet(page_set_module.PageSet):
"""Tough scheduler latency test cases."""
@@ -470,7 +441,7 @@
slow_handler=True,
bounce=False,
page_set=self))
- # Why: Slow handler blocks scroll start until touch ACK timeout
+ # Why: Slow handler blocks scroll start until touch ACK timeout
self.AddUserStory(EmptyTouchHandlerPage(
name='desktop_slow_handler',
desktop=True,
@@ -493,7 +464,7 @@
slow_handler=True,
bounce=True,
page_set=self))
- # Why: Scroll bounce with slow handler on desktop, blocks only once until
+ # Why: Scroll bounce with slow handler on desktop, blocks only once until
# ACK timeout.
self.AddUserStory(EmptyTouchHandlerPage(
name='bounce_desktop_slow_handler',
@@ -501,9 +472,5 @@
slow_handler=True,
bounce=True,
page_set=self))
- # Why: For measuring the latency of scroll-synchronized effects.
+ # Why: For measuring the latency of scroll-synchronized effects.
self.AddUserStory(SynchronizedScrollOffsetPage(page_set=self))
- # Why: Test loading a large amount of Javascript.
- self.AddUserStory(SecondBatchJsPage(page_set=self, variant='light'))
- self.AddUserStory(SecondBatchJsPage(page_set=self, variant='medium'))
- self.AddUserStory(SecondBatchJsPage(page_set=self, variant='heavy'))
« no previous file with comments | « no previous file | tools/perf/page_sets/tough_scheduling_cases/generate_second_batch_js.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698