Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1019803005: [turbofan] Factor out common switch-related code in instruction selectors. (Closed)

Created:
5 years, 9 months ago by titzer
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Factor out common switch-related code in instruction selectors. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/a6940f7aa3d7dc36e2c8713d11daccdf6837371b Cr-Commit-Position: refs/heads/master@{#27468}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -319 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +12 lines, -43 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +12 lines, -43 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +12 lines, -43 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 3 chunks +6 lines, -3 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +58 lines, -16 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +12 lines, -42 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +12 lines, -43 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +12 lines, -43 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +12 lines, -43 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
titzer
5 years, 9 months ago (2015-03-25 15:41:16 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/1019803005/diff/1/src/compiler/instruction-selector.h File src/compiler/instruction-selector.h (right): https://codereview.chromium.org/1019803005/diff/1/src/compiler/instruction-selector.h#newcode26 src/compiler/instruction-selector.h:26: struct SwitchInfo { Please move this struct to the ...
5 years, 9 months ago (2015-03-25 17:52:49 UTC) #2
titzer
https://codereview.chromium.org/1019803005/diff/1/src/compiler/instruction-selector.h File src/compiler/instruction-selector.h (right): https://codereview.chromium.org/1019803005/diff/1/src/compiler/instruction-selector.h#newcode26 src/compiler/instruction-selector.h:26: struct SwitchInfo { On 2015/03/25 17:52:48, Benedikt Meurer wrote: ...
5 years, 9 months ago (2015-03-26 08:27:38 UTC) #3
Benedikt Meurer
lgtm
5 years, 9 months ago (2015-03-26 08:28:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019803005/20001
5 years, 9 months ago (2015-03-26 08:48:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 09:08:50 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 09:09:01 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a6940f7aa3d7dc36e2c8713d11daccdf6837371b
Cr-Commit-Position: refs/heads/master@{#27468}

Powered by Google App Engine
This is Rietveld 408576698