Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1019773006: use non-masking, string interceptors in generated bindings (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 8 months ago
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

use non-masking, string interceptors in generated bindings R=jochen@chromium.org, haraken@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192749

Patch Set 1 #

Patch Set 2 : missed custom filter #

Patch Set 3 : rebase #

Patch Set 4 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -132 lines) Patch
M LayoutTests/http/tests/security/document-all.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/document-all-expected.txt View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 2 4 chunks +0 lines, -26 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 2 5 chunks +2 lines, -22 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 2 5 chunks +2 lines, -22 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 1 2 5 chunks +2 lines, -22 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 4 chunks +1 line, -6 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp View 1 2 2 chunks +2 lines, -9 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 2 5 chunks +2 lines, -22 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
dcarney
ptal
5 years, 9 months ago (2015-03-24 08:45:40 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-24 08:46:34 UTC) #4
haraken
LGTM
5 years, 9 months ago (2015-03-24 08:50:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019773006/20001
5 years, 9 months ago (2015-03-24 15:33:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/54020)
5 years, 9 months ago (2015-03-24 17:46:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019773006/60001
5 years, 8 months ago (2015-03-30 09:22:13 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 11:14:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192749

Powered by Google App Engine
This is Rietveld 408576698