Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp

Issue 1019773006: use non-masking, string interceptors in generated bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp
diff --git a/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp b/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp
index d77788420714a632d049715506d578de119f45d3..025feb4b62d1c600279820fc14dfa1e05ea84d16 100644
--- a/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp
+++ b/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp
@@ -47,16 +47,7 @@ static void indexedPropertyGetterCallback(uint32_t index, const v8::PropertyCall
static void namedPropertyGetter(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- if (!name->IsString())
- return;
auto nameString = name.As<v8::String>();
- v8::Local<v8::Context> context = info.GetIsolate()->GetCurrentContext();
- if (v8CallBoolean(info.Holder()->HasRealNamedProperty(context, nameString)))
- return;
- v8::Local<v8::Value> namedPropertyValue;
- if (info.Holder()->GetRealNamedPropertyInPrototypeChain(context, nameString).ToLocal(&namedPropertyValue))
- return;
-
TestSpecialOperationsNotEnumerable* impl = V8TestSpecialOperationsNotEnumerable::toImpl(info.Holder());
AtomicString propertyName = toCoreAtomicString(nameString);
String result = impl->anonymousNamedGetter(propertyName);
@@ -93,6 +84,8 @@ static void installV8TestSpecialOperationsNotEnumerableTemplate(v8::Local<v8::Fu
}
{
v8::NamedPropertyHandlerConfiguration config(TestSpecialOperationsNotEnumerableV8Internal::namedPropertyGetterCallback, 0, 0, 0, 0);
+ config.flags = static_cast<v8::PropertyHandlerFlags>(static_cast<int>(config.flags) | static_cast<int>(v8::PropertyHandlerFlags::kOnlyInterceptStrings));
+ config.flags = static_cast<v8::PropertyHandlerFlags>(static_cast<int>(config.flags) | static_cast<int>(v8::PropertyHandlerFlags::kNonMasking));
functionTemplate->InstanceTemplate()->SetHandler(config);
}

Powered by Google App Engine
This is Rietveld 408576698