gin/public/isolate_holder.h - Issue 1019483002: Add support to extension_shell and ash_shell to use external V8 snapshot files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/public/isolate_holder.h

Issue 1019483002: Add support to extension_shell and ash_shell to use external V8 snapshot files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove gyp changes Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gin/public/isolate_holder.h

diff --git a/gin/public/isolate_holder.h b/gin/public/isolate_holder.h

index 7968b1df0ba3edd8a9978105b927a494ec4cb5ef..7d7cb908bd1b7624096f22811c8c83037d4072c6 100644

--- a/gin/public/isolate_holder.h

+++ b/gin/public/isolate_holder.h

@@ -63,6 +63,8 @@ class GIN_EXPORT IsolateHolder {

int64 snapshot_offset,

int64 snapshot_size);

static bool LoadV8Snapshot();

+ static bool MapV8FilesForChildProcesses(int* natives_fd_out,

James Cook 2015/03/18 23:20:06 nit: Document what this function does.

rmcilroy 2015/03/19 14:41:39 Done - also renamed to be more precise.

+ int* snapshot_fd_out);

#endif // V8_USE_EXTERNAL_STARTUP_DATA

static void GetV8ExternalSnapshotData(const char** natives_data_out,

int* natives_size_out,

« gin/isolate_holder.cc ('K') | « gin/isolate_holder.cc ('k') | no next file » | no next file with comments »