Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: gin/public/isolate_holder.h

Issue 1019483002: Add support to extension_shell and ash_shell to use external V8 snapshot files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove gyp changes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« gin/isolate_holder.cc ('K') | « gin/isolate_holder.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GIN_PUBLIC_ISOLATE_HOLDER_H_ 5 #ifndef GIN_PUBLIC_ISOLATE_HOLDER_H_
6 #define GIN_PUBLIC_ISOLATE_HOLDER_H_ 6 #define GIN_PUBLIC_ISOLATE_HOLDER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "gin/gin_export.h" 10 #include "gin/gin_export.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 static const char kNativesFileName[]; 56 static const char kNativesFileName[];
57 static const char kSnapshotFileName[]; 57 static const char kSnapshotFileName[];
58 58
59 static bool LoadV8SnapshotFd(int natives_fd, 59 static bool LoadV8SnapshotFd(int natives_fd,
60 int64 natives_offset, 60 int64 natives_offset,
61 int64 natives_size, 61 int64 natives_size,
62 int snapshot_fd, 62 int snapshot_fd,
63 int64 snapshot_offset, 63 int64 snapshot_offset,
64 int64 snapshot_size); 64 int64 snapshot_size);
65 static bool LoadV8Snapshot(); 65 static bool LoadV8Snapshot();
66 static bool MapV8FilesForChildProcesses(int* natives_fd_out,
James Cook 2015/03/18 23:20:06 nit: Document what this function does.
rmcilroy 2015/03/19 14:41:39 Done - also renamed to be more precise.
67 int* snapshot_fd_out);
66 #endif // V8_USE_EXTERNAL_STARTUP_DATA 68 #endif // V8_USE_EXTERNAL_STARTUP_DATA
67 static void GetV8ExternalSnapshotData(const char** natives_data_out, 69 static void GetV8ExternalSnapshotData(const char** natives_data_out,
68 int* natives_size_out, 70 int* natives_size_out,
69 const char** snapshot_data_out, 71 const char** snapshot_data_out,
70 int* snapshot_size_out); 72 int* snapshot_size_out);
71 73
72 private: 74 private:
73 v8::Isolate* isolate_; 75 v8::Isolate* isolate_;
74 scoped_ptr<PerIsolateData> isolate_data_; 76 scoped_ptr<PerIsolateData> isolate_data_;
75 scoped_ptr<RunMicrotasksObserver> task_observer_; 77 scoped_ptr<RunMicrotasksObserver> task_observer_;
76 78
77 DISALLOW_COPY_AND_ASSIGN(IsolateHolder); 79 DISALLOW_COPY_AND_ASSIGN(IsolateHolder);
78 }; 80 };
79 81
80 } // namespace gin 82 } // namespace gin
81 83
82 #endif // GIN_PUBLIC_ISOLATE_HOLDER_H_ 84 #endif // GIN_PUBLIC_ISOLATE_HOLDER_H_
OLDNEW
« gin/isolate_holder.cc ('K') | « gin/isolate_holder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698