Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1019393003: Revert "ARM64: use jssp for stack slots" (Closed)

Created:
5 years, 9 months ago by jbramley
Modified:
5 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "ARM64: use jssp for stack slots" This reverts r21101. r21101 appears to be at fault for the ARM64 failures here: https://codereview.chromium.org/1023103003 BUG= Committed: https://crrev.com/a5ce9994a52cfeb915b785beb0eda1f5b64f9b6b Cr-Commit-Position: refs/heads/master@{#27393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -62 lines) Patch
M src/arm64/lithium-codegen-arm64.h View 3 chunks +2 lines, -19 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 11 chunks +3 lines, -43 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbramley
5 years, 9 months ago (2015-03-23 18:57:08 UTC) #2
Toon Verwaest
Lgtm (rubberstamp)
5 years, 9 months ago (2015-03-23 23:15:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019393003/1
5 years, 9 months ago (2015-03-24 09:11:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 09:51:35 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 09:51:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5ce9994a52cfeb915b785beb0eda1f5b64f9b6b
Cr-Commit-Position: refs/heads/master@{#27393}

Powered by Google App Engine
This is Rietveld 408576698