Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1023103003: If CallNew targets a constant global, set its state to monomorphic (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 9 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

If CallNew targets a constant global, set its state to monomorphic BUG= Committed: https://crrev.com/c46a93722012d3eff2e35402f0abec76e33595f3 Cr-Commit-Position: refs/heads/master@{#27399}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -77 lines) Patch
M src/ast.h View 1 2 chunks +8 lines, -1 line 0 comments Download
M src/ast.cc View 1 1 chunk +0 lines, -18 lines 0 comments Download
M src/hydrogen.cc View 1 4 chunks +24 lines, -58 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Toon Verwaest
PTAL
5 years, 9 months ago (2015-03-20 12:37:07 UTC) #2
mvstanton
lgtm
5 years, 9 months ago (2015-03-20 14:35:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023103003/20001
5 years, 9 months ago (2015-03-23 09:28:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/4091)
5 years, 9 months ago (2015-03-23 09:49:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023103003/20001
5 years, 9 months ago (2015-03-23 11:00:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/4100)
5 years, 9 months ago (2015-03-23 11:19:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023103003/20001
5 years, 9 months ago (2015-03-24 11:38:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-24 12:05:50 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 12:06:06 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c46a93722012d3eff2e35402f0abec76e33595f3
Cr-Commit-Position: refs/heads/master@{#27399}

Powered by Google App Engine
This is Rietveld 408576698