Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1019353004: Incremental linking setup for GN Windows build. (Closed)

Created:
5 years, 9 months ago by brettw
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Incremental linking setup for GN Windows build. Makes chrome.dll on Windows not use incremental linking since the ilk files get too large. This refactors the incremental linking configuration to make it easier to change the default. BUG= Committed: https://crrev.com/8900cf9444fc3e0adf6728926c96337ccadc9674 Cr-Commit-Position: refs/heads/master@{#321585}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : symbol level #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -12 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +1 line, -8 lines 0 comments Download
M build/config/win/BUILD.gn View 1 2 1 chunk +33 lines, -2 lines 0 comments Download
M chrome/BUILD.gn View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brettw
5 years, 9 months ago (2015-03-19 23:05:40 UTC) #2
Dirk Pranke
lgtm
5 years, 9 months ago (2015-03-19 23:15:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019353004/40001
5 years, 9 months ago (2015-03-20 16:56:35 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-20 17:08:32 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 17:09:13 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8900cf9444fc3e0adf6728926c96337ccadc9674
Cr-Commit-Position: refs/heads/master@{#321585}

Powered by Google App Engine
This is Rietveld 408576698