chrome/BUILD.gn - Issue 1019353004: Incremental linking setup for GN Windows build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 1019353004: Incremental linking setup for GN Windows build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: symbol level Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index b8cd7a195d2c33e2036fff786a75d87e997e3f09..f6bb6b7adb7945d83a18f33f94dd086dfa5e3b68 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -189,8 +189,9 @@ shared_library("main_dll") {

#deps += [ 'chrome_user32_delay_imports' ] TODO(GYP)

}

- # TODO(GYP) incremental linking flags in debug builds

- #'LinkIncremental': '<(msvs_large_module_debug_link_mode)',

+ # This is a large module that can't do incremental linking in some cases.

+ configs -= [ "//build/config/win:default_incremental_linking" ]

+ configs += [ "//build/config/win:default_large_module_incremental_linking" ]

# TODO(GYP) Lots of VCLinkerTool stuff on Windows.

« no previous file with comments | « build/config/win/BUILD.gn ('k') | no next file » | no next file with comments »