Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Unified Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 1019313003: Use c++11 range loops in accessibility (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXMenuList.cpp ('k') | Source/modules/accessibility/AXObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXNodeObject.cpp
diff --git a/Source/modules/accessibility/AXNodeObject.cpp b/Source/modules/accessibility/AXNodeObject.cpp
index 75cd4a77849ba1a7e80ddbcd4286a37584464f44..b57938e365e7efa71f7380b9b08ee9f39cda4570 100644
--- a/Source/modules/accessibility/AXNodeObject.cpp
+++ b/Source/modules/accessibility/AXNodeObject.cpp
@@ -339,11 +339,8 @@ void AXNodeObject::elementsFromAttribute(WillBeHeapVector<RawPtrWillBeMember<Ele
Vector<String> idVector;
idList.split(' ', idVector);
- unsigned size = idVector.size();
- for (unsigned i = 0; i < size; ++i) {
- AtomicString idName(idVector[i]);
- Element* idElement = scope.getElementById(idName);
- if (idElement)
+ for (const auto& idName : idVector) {
+ if (Element* idElement = scope.getElementById(AtomicString(idName)))
elements.append(idElement);
}
}
@@ -1633,8 +1630,8 @@ void AXNodeObject::addChildren()
for (Node& child : NodeTraversal::childrenOf(*m_node))
addChild(axObjectCache()->getOrCreate(&child));
- for (unsigned i = 0; i < m_children.size(); ++i)
- m_children[i].get()->setParent(this);
+ for (const auto& child : m_children)
+ child->setParent(this);
}
void AXNodeObject::addChild(AXObject* child)
@@ -1653,7 +1650,7 @@ void AXNodeObject::insertChild(AXObject* child, unsigned index)
child->clearChildren();
if (child->accessibilityIsIgnored()) {
- const AccessibilityChildrenVector& children = child->children();
+ const auto& children = child->children();
size_t length = children.size();
for (size_t i = 0; i < length; ++i)
m_children.insert(index + i, children[i]);
@@ -1979,9 +1976,8 @@ void AXNodeObject::ariaLabeledByText(Vector<AccessibilityText>& textOrder) const
WillBeHeapVector<RawPtrWillBeMember<Element>> elements;
ariaLabeledByElements(elements);
- unsigned length = elements.size();
- for (unsigned k = 0; k < length; k++) {
- RefPtr<AXObject> axElement = axObjectCache()->getOrCreate(elements[k]);
+ for (const auto& element : elements) {
+ RefPtr<AXObject> axElement = axObjectCache()->getOrCreate(element);
textOrder.append(AccessibilityText(ariaLabeledBy, AlternativeText, axElement));
}
}
« no previous file with comments | « Source/modules/accessibility/AXMenuList.cpp ('k') | Source/modules/accessibility/AXObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698