Use c++11 range loops in accessibility

Source/modules/accessibility/AXNodeObject.cpp

 /*
 * Copyright (C) 2012, Google Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1.  Redistributions of source code must retain the above copyright
 *     notice, this list of conditions and the following disclaimer.
 * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 321 matching lines @@
     TreeScope& scope = node->treeScope();
 
     String idList = getAttribute(attribute).string();
     if (idList.isEmpty())
         return;
 
     idList.replace('\n', ' ');
     Vector<String> idVector;
     idList.split(' ', idVector);
 
-    unsigned size = idVector.size();
-    for (unsigned i = 0; i < size; ++i) {
-        AtomicString idName(idVector[i]);
-        Element* idElement = scope.getElementById(idName);
-        if (idElement)
+    for (const auto& idName : idVector) {
+        if (Element* idElement = scope.getElementById(AtomicString(idName)))
             elements.append(idElement);
     }
 }
 
 // If you call node->hasEditableStyle() since that will return true if an ancestor is editable.
 // This only returns true if this is the element that actually has the contentEditable attribute set.
 bool AXNodeObject::hasContentEditableAttributeSet() const
 {
     if (!hasAttribute(contenteditableAttr))
         return false;
@@ skipping 1269 matching lines @@
 
     m_haveChildren = true;
 
     // The only time we add children from the DOM tree to a node with a layoutObject is when it's a canvas.
     if (layoutObject() && !isHTMLCanvasElement(*m_node))
         return;
 
     for (Node& child : NodeTraversal::childrenOf(*m_node))
         addChild(axObjectCache()->getOrCreate(&child));
 
-    for (unsigned i = 0; i < m_children.size(); ++i)
-        m_children[i].get()->setParent(this);
+    for (const auto& child : m_children)
+        child->setParent(this);
 }
 
 void AXNodeObject::addChild(AXObject* child)
 {
     insertChild(child, m_children.size());
 }
 
 void AXNodeObject::insertChild(AXObject* child, unsigned index)
 {
     if (!child)
         return;
 
     // If the parent is asking for this child's children, then either it's the first time (and clearing is a no-op),
     // or its visibility has changed. In the latter case, this child may have a stale child cached.
     // This can prevent aria-hidden changes from working correctly. Hence, whenever a parent is getting children, ensure data is not stale.
     child->clearChildren();
 
     if (child->accessibilityIsIgnored()) {
-        const AccessibilityChildrenVector& children = child->children();
+        const auto& children = child->children();
         size_t length = children.size();
         for (size_t i = 0; i < length; ++i)
             m_children.insert(index + i, children[i]);
     } else {
         ASSERT(child->parentObject() == this);
         m_children.insert(index, child);
     }
 }
 
 bool AXNodeObject::canHaveChildren() const
@@ skipping 305 matching lines @@
     }
 }
 
 void AXNodeObject::ariaLabeledByText(Vector<AccessibilityText>& textOrder) const
 {
     String ariaLabeledBy = ariaLabeledByAttribute();
     if (!ariaLabeledBy.isEmpty()) {
         WillBeHeapVector<RawPtrWillBeMember<Element>> elements;
         ariaLabeledByElements(elements);
 
-        unsigned length = elements.size();
-        for (unsigned k = 0; k < length; k++) {
-            RefPtr<AXObject> axElement = axObjectCache()->getOrCreate(elements[k]);
+        for (const auto& element : elements) {
+            RefPtr<AXObject> axElement = axObjectCache()->getOrCreate(element);
             textOrder.append(AccessibilityText(ariaLabeledBy, AlternativeText, axElement));
         }
     }
 }
 
 void AXNodeObject::changeValueByPercent(float percentChange)
 {
     float range = maxValueForRange() - minValueForRange();
     float value = valueForRange();
 
     value += range * (percentChange / 100);
     setValue(String::number(value));
 
     axObjectCache()->postNotification(node(), AXObjectCacheImpl::AXValueChanged, true);
 }
 
 } // namespace blink