Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Unified Diff: chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc

Issue 1019283004: Switch to direct use of OwnerSettingsServiceChromeOS::Set() in tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use settings provider to set read-only device settings. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc b/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc
index d8a056744e810a4ade376fdf6f31f6e1ac389e82..bf488117e8e1fe9bf0be450aaa5c7fa6e33bbc06 100644
--- a/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc
+++ b/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc
@@ -15,7 +15,9 @@
#include "base/strings/string_util.h"
#include "base/sys_info.h"
#include "base/values.h"
+#include "chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h"
#include "chrome/browser/chromeos/settings/cros_settings.h"
+#include "chrome/browser/profiles/profile.h"
#include "chrome/grit/chromium_strings.h"
#include "chrome/grit/generated_resources.h"
#include "chromeos/chromeos_switches.h"
@@ -129,6 +131,7 @@ void KioskAppsHandler::RegisterMessages() {
web_ui()->RegisterMessageCallback("setDisableBailoutShortcut",
base::Bind(&KioskAppsHandler::HandleSetDisableBailoutShortcut,
base::Unretained(this)));
+ owner_settings_service_ = OwnerSettingsServiceChromeOS::FromWebUI(web_ui());
}
void KioskAppsHandler::GetLocalizedValues(content::WebUIDataSource* source) {
@@ -281,7 +284,7 @@ void KioskAppsHandler::HandleAddKioskApp(const base::ListValue* args) {
return;
}
- kiosk_app_manager_->AddApp(app_id);
+ kiosk_app_manager_->AddApp(app_id, owner_settings_service_);
}
void KioskAppsHandler::HandleRemoveKioskApp(const base::ListValue* args) {
@@ -291,7 +294,7 @@ void KioskAppsHandler::HandleRemoveKioskApp(const base::ListValue* args) {
std::string app_id;
CHECK(args->GetString(0, &app_id));
- kiosk_app_manager_->RemoveApp(app_id);
+ kiosk_app_manager_->RemoveApp(app_id, owner_settings_service_);
}
void KioskAppsHandler::HandleEnableKioskAutoLaunch(
@@ -302,7 +305,7 @@ void KioskAppsHandler::HandleEnableKioskAutoLaunch(
std::string app_id;
CHECK(args->GetString(0, &app_id));
- kiosk_app_manager_->SetAutoLaunchApp(app_id);
+ kiosk_app_manager_->SetAutoLaunchApp(app_id, owner_settings_service_);
}
void KioskAppsHandler::HandleDisableKioskAutoLaunch(
@@ -317,7 +320,7 @@ void KioskAppsHandler::HandleDisableKioskAutoLaunch(
if (startup_app_id != app_id)
return;
- kiosk_app_manager_->SetAutoLaunchApp("");
+ kiosk_app_manager_->SetAutoLaunchApp("", owner_settings_service_);
}
void KioskAppsHandler::HandleSetDisableBailoutShortcut(
@@ -328,7 +331,7 @@ void KioskAppsHandler::HandleSetDisableBailoutShortcut(
bool disable_bailout_shortcut;
CHECK(args->GetBoolean(0, &disable_bailout_shortcut));
- CrosSettings::Get()->SetBoolean(
+ owner_settings_service_->SetBoolean(
kAccountsPrefDeviceLocalAccountAutoLoginBailoutEnabled,
!disable_bailout_shortcut);
}
@@ -350,7 +353,7 @@ void KioskAppsHandler::ShowError(const std::string& app_id) {
web_ui()->CallJavascriptFunction("extensions.KioskAppsOverlay.showError",
app_id_value);
- kiosk_app_manager_->RemoveApp(app_id);
+ kiosk_app_manager_->RemoveApp(app_id, owner_settings_service_);
}
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698