Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: chromeos/settings/cros_settings_provider.h

Issue 1019283004: Switch to direct use of OwnerSettingsServiceChromeOS::Set() in tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use settings provider to set read-only device settings. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/settings/cros_settings_provider.h
diff --git a/chromeos/settings/cros_settings_provider.h b/chromeos/settings/cros_settings_provider.h
index 491113be42a45e0cf1402ac92d96c88ae4d82ae3..4ca6d715e9db31182bf0b09de2c33ce97eb7a6da 100644
--- a/chromeos/settings/cros_settings_provider.h
+++ b/chromeos/settings/cros_settings_provider.h
@@ -44,6 +44,13 @@ class CHROMEOS_EXPORT CrosSettingsProvider {
// Sets |in_value| to given |path| in cros settings.
void Set(const std::string& path, const base::Value& in_value);
+ // Convenience forms of Set(). These methods will replace any existing
Mattias Nissler (ping if slow) 2015/03/30 14:45:46 These should be defined in StubSettingsProvider -
+ // value at that |path|, even if it has a different type.
+ void SetBoolean(const std::string& path, bool in_value);
+ void SetInteger(const std::string& path, int in_value);
+ void SetDouble(const std::string& path, double in_value);
+ void SetString(const std::string& path, const std::string& in_value);
+
// Gets settings value of given |path| to |out_value|.
virtual const base::Value* Get(const std::string& path) const = 0;

Powered by Google App Engine
This is Rietveld 408576698