Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1019273002: Revert "Tweaks layoutTests to use eventSender.setTouchPointRadius correctly" (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "Tweaks layoutTests to use eventSender.setTouchPointRadius correctly" This reverts commit e0717a58a20cc4d14501cd6e9b9164789b7581eb Reason for revert: Touch event test failures, https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_32/34636/layout-test-results/results.html Original issue's description: > Tweaks layoutTests to use eventSender.setTouchPointRadius correctly > > A link to the Chrome patch (event_sender.cc) https://codereview.chromium.org/990183003/ > > BUG= > > Review URL: https://codereview.chromium.org/990193002 > > git-svn-id: svn://svn.chromium.org/blink/trunk@192088 bbb929c8-8fbe-4397-9dbb-9b2b20218538 TBR=rbyers@chromium.org,d.pikalov@partner.samsung.com,fdegans@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=468704 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -25 lines) Patch
M LayoutTests/fast/events/touch/script-tests/basic-single-touch-events.js View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/events/touch/touch-browser-zoom-scales-radius.html View 2 chunks +7 lines, -15 lines 0 comments Download
M LayoutTests/fast/events/touch/touch-browser-zoom-scales-radius-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/touch/touch-fractional-coordinates.html View 2 chunks +3 lines, -7 lines 0 comments Download
M LayoutTests/fast/events/touch/touch-fractional-coordinates-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sof
ptal
5 years, 9 months ago (2015-03-19 10:57:20 UTC) #1
sof
lgtm
5 years, 9 months ago (2015-03-19 11:42:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019273002/1
5 years, 9 months ago (2015-03-19 11:42:33 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 11:43:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192154

Powered by Google App Engine
This is Rietveld 408576698