cc: Remove the unused function appendCompositingItem with 3 parameters

cc/blink/web_display_item_list_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_BLINK_WEB_DISPLAY_ITEM_LIST_IMPL_H_
 #define CC_BLINK_WEB_DISPLAY_ITEM_LIST_IMPL_H_
 
 #include "base/memory/ref_counted.h"
 #include "cc/blink/cc_blink_export.h"
 #include "cc/resources/display_item_list.h"
-#include "third_party/WebKit/public/platform/WebBlendMode.h"
-#include "third_party/WebKit/public/platform/WebContentLayerClient.h"
 #include "third_party/WebKit/public/platform/WebDisplayItemList.h"
 #include "third_party/WebKit/public/platform/WebFloatPoint.h"
 #include "third_party/WebKit/public/platform/WebVector.h"
 #include "third_party/skia/include/core/SkRegion.h"

[enne (OOO), 2015/03/26 20:18:09]

Did you mean to not change this?

[huayong.xu, 2015/03/27 01:55:23]

In Patch Set 2, I removed WebFloatPoint.h incorrectly. So I add it again in
Patch Set 3.
After I committed Patch Set 3, your comment 'Maybe this should be WebFloatRect?'
is discarded.
I did not change SkRegion.h.

[enne (OOO), 2015/03/27 17:52:19]

Sorry, but my original comment still stands.  If you're cleaning up includes,
this header does not need WebFloatPoint.  It uses WebFloatRect.  So, change this
line to WebFloatRect and don't include it in the .cc file?

[huayong.xu, 2015/03/30 03:51:15]

I got it.
Instead of changing includes, I add some forward declarations.
What do you think?

 #include "third_party/skia/include/core/SkXfermode.h"
 #include "ui/gfx/geometry/point_f.h"
 
 class SkColorFilter;
 class SkImageFilter;
 class SkMatrix44;
 class SkPath;
 class SkPicture;
 class SkRRect;
 
@@ skipping 13 matching lines @@
       const blink::WebVector<SkRRect>& rounded_clip_rects);
   virtual void appendEndClipItem();
   virtual void appendClipPathItem(const SkPath& clip_path,
                                   SkRegion::Op clip_op,
                                   bool antialias);
   virtual void appendEndClipPathItem();
   virtual void appendFloatClipItem(const blink::WebFloatRect& clip_rect);
   virtual void appendEndFloatClipItem();
   virtual void appendTransformItem(const SkMatrix44& matrix);
   virtual void appendEndTransformItem();
-  // TODO(pdr): Remove this once the blink-side callers have been removed.
-  virtual void appendCompositingItem(float opacity,
-                                     SkXfermode::Mode,
-                                     SkColorFilter*);
   virtual void appendCompositingItem(float opacity,
                                      SkXfermode::Mode,
                                      SkRect* bounds,
                                      SkColorFilter*);
   virtual void appendEndCompositingItem();
   virtual void appendFilterItem(const blink::WebFilterOperations& filters,
                                 const blink::WebFloatRect& bounds);
   virtual void appendEndFilterItem();
   virtual void appendScrollItem(const blink::WebSize& scrollOffset,
                                 ScrollContainerId);
   virtual void appendEndScrollItem();
 
  private:
   scoped_refptr<cc::DisplayItemList> display_item_list_;
 
   DISALLOW_COPY_AND_ASSIGN(WebDisplayItemListImpl);
 };
 
 }  // namespace cc_blink
 
 #endif  // CC_BLINK_WEB_DISPLAY_ITEM_LIST_IMPL_H_