cc: Remove the unused function appendCompositingItem with 3 parameters

cc: Remove the unused function appendCompositingItem with 3 parameters

Remove a TODO, because Blink had already removed this function calls.
Meanwhile remove some unused includes.

Committed: https://crrev.com/45a8506acbf566eac38c7ed0624a45669b45de69
Cr-Commit-Position: refs/heads/master@{#322808}

[huayong.xu, 2015-03-19 09:55:07]

huayong.xu@samsung.com changed reviewers:
+ pdr@chromium.org

[huayong.xu, 2015-03-19 09:56:03]

Please review.

[enne (OOO), 2015-03-19 19:10:12]

enne@chromium.org changed reviewers:
+ enne@chromium.org

[enne (OOO), 2015-03-19 19:10:13]

lgtm

https://codereview.chromium.org/1019263002/diff/20001/cc/blink/web_display_it...
File cc/blink/web_display_item_list_impl.h (left):

https://codereview.chromium.org/1019263002/diff/20001/cc/blink/web_display_it...
cc/blink/web_display_item_list_impl.h:14: #include
"third_party/WebKit/public/platform/WebFloatPoint.h"
Maybe this should be WebFloatRect?

[enne (OOO), 2015-03-19 19:11:00]

Re: your patch description.  If bug=none, just remove that line.  Also, please
wrap your patch description at 72 columns.

[huayong.xu, 2015-03-20 00:44:15]

On 2015/03/19 19:10:13, enne wrote:
> lgtm
> 
>
https://codereview.chromium.org/1019263002/diff/20001/cc/blink/web_display_it...
> File cc/blink/web_display_item_list_impl.h (left):
> 
>
https://codereview.chromium.org/1019263002/diff/20001/cc/blink/web_display_it...
> cc/blink/web_display_item_list_impl.h:14: #include
> "third_party/WebKit/public/platform/WebFloatPoint.h"
> Maybe this should be WebFloatRect?

Yes, right. Done.

[huayong.xu, 2015-03-20 00:44:36]

On 2015/03/19 19:11:00, enne wrote:
> Re: your patch description.  If bug=none, just remove that line.  Also, please
> wrap your patch description at 72 columns.

Done.

[huayong.xu, 2015-03-26 07:07:44]

PTAL, thanks!

[enne (OOO), 2015-03-26 20:18:12]

https://codereview.chromium.org/1019263002/diff/40001/cc/blink/web_display_it...
File cc/blink/web_display_item_list_impl.h (right):

https://codereview.chromium.org/1019263002/diff/40001/cc/blink/web_display_it...
cc/blink/web_display_item_list_impl.h:14: #include
"third_party/skia/include/core/SkRegion.h"
Did you mean to not change this?

[huayong.xu, 2015-03-27 01:55:23]

Please take a look again. Thanks.

https://codereview.chromium.org/1019263002/diff/40001/cc/blink/web_display_it...
File cc/blink/web_display_item_list_impl.h (right):

https://codereview.chromium.org/1019263002/diff/40001/cc/blink/web_display_it...
cc/blink/web_display_item_list_impl.h:14: #include
"third_party/skia/include/core/SkRegion.h"
On 2015/03/26 20:18:09, enne wrote:
> Did you mean to not change this?


In Patch Set 2, I removed WebFloatPoint.h incorrectly. So I add it again in
Patch Set 3.
After I committed Patch Set 3, your comment 'Maybe this should be WebFloatRect?'
is discarded.
I did not change SkRegion.h.

[enne (OOO), 2015-03-27 17:52:20]

https://codereview.chromium.org/1019263002/diff/40001/cc/blink/web_display_it...
File cc/blink/web_display_item_list_impl.h (right):

https://codereview.chromium.org/1019263002/diff/40001/cc/blink/web_display_it...
cc/blink/web_display_item_list_impl.h:14: #include
"third_party/skia/include/core/SkRegion.h"
Sorry, but my original comment still stands.  If you're cleaning up includes,
this header does not need WebFloatPoint.  It uses WebFloatRect.  So, change this
line to WebFloatRect and don't include it in the .cc file?

[huayong.xu, 2015-03-30 03:51:15]

Please take a look again? Thanks.

https://codereview.chromium.org/1019263002/diff/40001/cc/blink/web_display_it...
File cc/blink/web_display_item_list_impl.h (right):

https://codereview.chromium.org/1019263002/diff/40001/cc/blink/web_display_it...
cc/blink/web_display_item_list_impl.h:14: #include
"third_party/skia/include/core/SkRegion.h"
On 2015/03/27 17:52:19, enne wrote:
> Sorry, but my original comment still stands.  If you're cleaning up includes,
> this header does not need WebFloatPoint.  It uses WebFloatRect.  So, change
this
> line to WebFloatRect and don't include it in the .cc file?

I got it.
Instead of changing includes, I add some forward declarations.
What do you think?

[enne (OOO), 2015-03-30 16:54:07]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2015-03-30 16:54:09]

lgtm

[commit-bot: I haz the power, 2015-03-30 17:03:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1019263002/60001

[commit-bot: I haz the power, 2015-03-30 18:01:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-30 18:02:29]

Patchset 4 (id:??) landed as
https://crrev.com/45a8506acbf566eac38c7ed0624a45669b45de69
Cr-Commit-Position: refs/heads/master@{#322808}