Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc

Issue 1019143003: Fix crash when user closes card unmasking dialog after verification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
diff --git a/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc b/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
index f6487bfc3bc6b505e562a511af166cb7fc79574a..d0fd788bfd0bce5d9b46a2491f362b9247cc0535 100644
--- a/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
+++ b/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
@@ -58,7 +58,8 @@ class CardUnmaskPromptViews : public CardUnmaskPromptView,
error_label_(nullptr),
storage_checkbox_(nullptr),
progress_overlay_(nullptr),
- progress_label_(nullptr) {}
+ progress_label_(nullptr),
+ weak_ptr_factory_(this) {}
~CardUnmaskPromptViews() override {
if (controller_)
@@ -90,7 +91,7 @@ class CardUnmaskPromptViews : public CardUnmaskPromptView,
IDS_AUTOFILL_CARD_UNMASK_VERIFICATION_SUCCESS));
base::MessageLoop::current()->PostDelayedTask(
FROM_HERE, base::Bind(&CardUnmaskPromptViews::ClosePrompt,
- base::Unretained(this)),
+ weak_ptr_factory_.GetWeakPtr()),
base::TimeDelta::FromSeconds(1));
} else {
// TODO(estade): it's somewhat jarring when the error comes back too
@@ -419,6 +420,8 @@ class CardUnmaskPromptViews : public CardUnmaskPromptView,
views::View* progress_overlay_;
views::Label* progress_label_;
+ base::WeakPtrFactory<CardUnmaskPromptViews> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(CardUnmaskPromptViews);
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698