Fix crash when user closes card unmasking dialog after verification

chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_models.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_types.h"
 #include "chrome/browser/ui/autofill/card_unmask_prompt_controller.h"
 #include "chrome/browser/ui/autofill/card_unmask_prompt_view.h"
@@ skipping 40 matching lines @@
   explicit CardUnmaskPromptViews(CardUnmaskPromptController* controller)
       : controller_(controller),
         main_contents_(nullptr),
         permanent_error_label_(nullptr),
         cvc_input_(nullptr),
         month_input_(nullptr),
         year_input_(nullptr),
         error_label_(nullptr),
         storage_checkbox_(nullptr),
         progress_overlay_(nullptr),
-        progress_label_(nullptr) {}
+        progress_label_(nullptr),
+        weak_ptr_factory_(this) {}
 
   ~CardUnmaskPromptViews() override {
     if (controller_)
       controller_->OnUnmaskDialogClosed();
   }
 
   void Show() {
     constrained_window::ShowWebModalDialogViews(this,
                                                 controller_->GetWebContents());
   }
@@ skipping 11 matching lines @@
     Layout();
   }
 
   void GotVerificationResult(const base::string16& error_message,
                              bool allow_retry) override {
     if (error_message.empty()) {
       progress_label_->SetText(l10n_util::GetStringUTF16(
           IDS_AUTOFILL_CARD_UNMASK_VERIFICATION_SUCCESS));
       base::MessageLoop::current()->PostDelayedTask(
           FROM_HERE, base::Bind(&CardUnmaskPromptViews::ClosePrompt,
-                                base::Unretained(this)),
+                                weak_ptr_factory_.GetWeakPtr()),
           base::TimeDelta::FromSeconds(1));
     } else {
       // TODO(estade): it's somewhat jarring when the error comes back too
       // quickly.
       progress_overlay_->SetVisible(false);
 
       if (allow_retry) {
         SetInputsEnabled(true);
 
         // If there is more than one input showing, don't mark anything as
@@ skipping 308 matching lines @@
   YearComboboxModel year_combobox_model_;
 
   // The error label for most errors, which lives beneath the inputs.
   views::Label* error_label_;
 
   views::Checkbox* storage_checkbox_;
 
   views::View* progress_overlay_;
   views::Label* progress_label_;
 
+  base::WeakPtrFactory<CardUnmaskPromptViews> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(CardUnmaskPromptViews);
 };
 
 }  // namespace
 
 // static
 CardUnmaskPromptView* CardUnmaskPromptView::CreateAndShow(
     CardUnmaskPromptController* controller) {
   CardUnmaskPromptViews* view = new CardUnmaskPromptViews(controller);
   view->Show();
   return view;
 }
 
 }  // namespace autofill