Issue 1019103002: Log to android logger when loads fail in oknet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1019103002: Log to android logger when loads fail in oknet. (Closed)

Created:
5 years, 9 months ago by eseidel

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Log to android logger when loads fail in oknet. This makes it much easier to debug (otherwise silent) 404s of images, etc. R=abarth@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/28925de0b2f63a2a02e900b100ee4f768d1ffa43

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java	View		4 chunks	+10 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

LGTM https://codereview.chromium.org/1019103002/diff/1/sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java File sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java (right): https://codereview.chromium.org/1019103002/diff/1/sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java#newcode155 sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java:155: if (urlResponse.statusCode != 200) { >= 400 ?

5 years, 9 months ago (2015-03-18 21:10:57 UTC) #2

eseidel

5 years, 9 months ago (2015-03-18 21:15:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
28925de0b2f63a2a02e900b100ee4f768d1ffa43 (presubmit successful).

Expand Messages | Collapse Messages