Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java

Issue 1019103002: Log to android logger when loads fail in oknet. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java
diff --git a/sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java b/sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java
index defbb49b1c9cab488b4b2b89534bbedeeb9a42ad..106bfb00a606602b6931cd1cd96655970491e970 100644
--- a/sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java
+++ b/sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java
@@ -4,6 +4,8 @@
package org.domokit.oknet;
+import android.util.Log;
+
import com.squareup.okhttp.Call;
import com.squareup.okhttp.Callback;
import com.squareup.okhttp.Headers;
@@ -31,10 +33,12 @@ import java.nio.charset.Charset;
import okio.BufferedSource;
+
/**
* OkHttp implementation of UrlLoader.
*/
public class UrlLoaderImpl implements UrlLoader {
+ private static final String TAG = "UrlLoaderImpl";
private Core mCore;
private OkHttpClient mClient;
private boolean mIsLoading;
@@ -129,6 +133,7 @@ public class UrlLoaderImpl implements UrlLoader {
call.enqueue(new Callback() {
@Override
public void onFailure(Request request, IOException e) {
+ Log.w(TAG, "Network failure loading " + request.urlString());
mError = new NetworkError();
// TODO(abarth): Which mError.code should we set?
mError.description = e.toString();
@@ -147,6 +152,11 @@ public class UrlLoaderImpl implements UrlLoader {
urlResponse.statusCode = response.code();
urlResponse.statusLine = response.message();
+ if (urlResponse.statusCode != 200) {
abarth-chromium 2015/03/18 21:10:57 >= 400 ?
+ Log.w(TAG, "Failed to load: " + urlResponse.url + " ("
+ + urlResponse.statusCode + ")");
+ }
+
Headers headers = response.headers();
urlResponse.headers = new String[headers.size()];
for (int i = 0; i < headers.size(); ++i) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698