Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sky/framework/components/menu_item.dart

Issue 1019023003: Improve Material ink effects (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sky/engine/core/events/GestureEvent.h ('K') | « sky/framework/components/material.dart ('k') | sky/framework/components/popup_menu_item.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/components/menu_item.dart
diff --git a/sky/framework/components/menu_item.dart b/sky/framework/components/menu_item.dart
index 8ac83970d7d242cdcfd4fb3c7fdfa869eed9955f..fe31bf9b7429a3b42ea1a4df5fdf201bb8d6207b 100644
--- a/sky/framework/components/menu_item.dart
+++ b/sky/framework/components/menu_item.dart
@@ -5,7 +5,7 @@
import '../fn.dart';
import 'button_base.dart';
import 'icon.dart';
-import 'material.dart';
+import 'ink_well.dart';
class MenuItem extends ButtonBase {
static final Style _style = new Style('''
@@ -40,7 +40,7 @@ class MenuItem extends ButtonBase {
MenuItem({ Object key, this.icon, this.children }) : super(key: key);
Node buildContent() {
- return new Material (
+ return new InkWell (
style: highlight ? _highlightStyle : _style,
children: [
new Icon(
« sky/engine/core/events/GestureEvent.h ('K') | « sky/framework/components/material.dart ('k') | sky/framework/components/popup_menu_item.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698