Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sky/framework/components/popup_menu_item.dart

Issue 1019023003: Improve Material ink effects (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sky/engine/core/events/GestureEvent.h ('K') | « sky/framework/components/menu_item.dart ('k') | sky/framework/components/radio.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/components/popup_menu_item.dart
diff --git a/sky/framework/components/popup_menu_item.dart b/sky/framework/components/popup_menu_item.dart
index 8a5a7181bd23cb6662f37f79814d6b6e8bf360b0..7468ba0650ca190fef9182b5494475db538bf74d 100644
--- a/sky/framework/components/popup_menu_item.dart
+++ b/sky/framework/components/popup_menu_item.dart
@@ -4,7 +4,7 @@
import '../animation/animated_value.dart';
import '../fn.dart';
-import 'material.dart';
+import 'ink_well.dart';
class PopupMenuItem extends Component {
static final Style _style = new Style('''
@@ -25,7 +25,7 @@ class PopupMenuItem extends Component {
Node build() {
_opacity.ensureListening();
- return new Material(
+ return new InkWell(
style: _style,
inlineStyle: _opacity.value == null ? null : 'opacity: ${_opacity.value}',
children: children
« sky/engine/core/events/GestureEvent.h ('K') | « sky/framework/components/menu_item.dart ('k') | sky/framework/components/radio.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698