Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Issue 1019023003: Improve Material ink effects (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Improve Material ink effects 1) Factors InkWell out of Material so that components can use an ink well without needing the shadow/level machinery. 2) Makes the ink effect move at a different velocity once the tap has actually occurred, converging with the spec. We don't have the right speeds yet, but at least we're approaching the right shape. 3) To support (2), added a primaryPointer attribute to GestureEvents to let authors coorelate gesturetapdown events with later gesturetap events. 4) To support (2), modernized SplashAnimation to used AnimatedValue and friends. 5) Added more constants to view-configuration.dart that match Android. I've also removed the cancelling of the ink effect on scroll. The proper way to do that is to notice that someone in the event chain is listening for scrollstart and delay the beginning of the ink effect for some period of time. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6bedc53cb6045b98406cae563bf5d325d4bd5afc

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -148 lines) Patch
M sky/engine/core/events/GestureEvent.h View 3 chunks +3 lines, -0 lines 1 comment Download
M sky/engine/core/events/GestureEvent.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/core/events/GestureEvent.idl View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/public/platform/WebInputEvent.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/examples/stocks-fn/lib/stock_row.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/framework/components/ink_splash.dart View 1 chunk +49 lines, -25 lines 0 comments Download
A + sky/framework/components/ink_well.dart View 3 chunks +24 lines, -40 lines 0 comments Download
M sky/framework/components/material.dart View 3 chunks +5 lines, -68 lines 0 comments Download
M sky/framework/components/menu_item.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/framework/components/popup_menu_item.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/framework/components/radio.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sky/framework/fn.dart View 4 chunks +5 lines, -0 lines 0 comments Download
M sky/framework/theme/view-configuration.dart View 1 chunk +22 lines, -6 lines 0 comments Download
M sky/services/viewport/input_event.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M sky/shell/org/domokit/sky/shell/GestureProvider.java View 1 chunk +4 lines, -2 lines 0 comments Download
M sky/shell/ui/input_event_converter.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-19 17:52:04 UTC) #1
eseidel
lgtm https://codereview.chromium.org/1019023003/diff/1/sky/engine/core/events/GestureEvent.h File sky/engine/core/events/GestureEvent.h (right): https://codereview.chromium.org/1019023003/diff/1/sky/engine/core/events/GestureEvent.h#newcode42 sky/engine/core/events/GestureEvent.h:42: int primaryPointer() const { return m_primaryPointer; } dart ...
5 years, 9 months ago (2015-03-19 18:00:36 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-19 18:17:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6bedc53cb6045b98406cae563bf5d325d4bd5afc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698